Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce formal review period of the proposal #8

Closed
antoviaque opened this issue Dec 7, 2022 · 5 comments
Closed

Announce formal review period of the proposal #8

antoviaque opened this issue Dec 7, 2022 · 5 comments
Assignees

Comments

@antoviaque
Copy link

We have discussed doing a formal review of the proposal at openedx/open-edx-proposals#372 until the next meeting on January 10th, to both give ourselves time to do the technical validation work captured in the issues on the current repo, and allow the rest of the community to join in the review, seeing that it is becoming more serious and defined now.

The review period should thus be until January 9th to allow us to debrief it during the next meeting - and in the announcement it's also worth asking people to review & comment before the end of this month, to keep some time to resolve discussions. The announcement category of discourse can be used to ensure we maximize the awareness of this within the community.

@antoviaque
Copy link
Author

Also noted during the meeting: it would be a good step to involve 2U DevOps to have them review the proposal. Kelly Buchanan offered to pass it on to the relevant people at 2U, she just need to be pinged on Slack with the link to the announcement forum thread when it's posted.

@felipemontoya
Copy link
Member

Here is the post of the announcement https://discuss.openedx.org/t/helm-charts-collaboration-for-large-instances/8875

@antoviaque
Copy link
Author

To follow-up on the short discussion we had on this during the meeting yesterday, @bradenmacdonald was mentioning that we don't have full validation of the approach in practice for now. Imho it would still be important to provide a conclusion to the formal review period we had. Since there have been no objections, and that this is still the way we have agreed to move forward together as a group, we could confirm that this is the way we're moving forward for now by merging openedx/open-edx-proposals#372 ? We could always revise it later on if we change something.

Although @keithgg you mentioned having spotted some issues during the meeting - could you post a description of them in a ticket on this repo?

Also, @adzuci have you or someone else at 2U been able to review the proposal? It would be really helpful to know what you think of it, so a formal review would be helpful - it could also help to identify ways to work together?

@antoviaque
Copy link
Author

Note from the meeting: we seem all good to merge the ADR, but @felipemontoya would like to get formal approvals as 👍 on the PR from other core contributors before merging, which he has requested there from @bradenmacdonald @regisb @gabor-boros @jfavellar90 and @arbrandes

@felipemontoya
Copy link
Member

The ADR was finally merged with status "provisional".

openedx/open-edx-proposals#372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants