Skip to content

test: check both dev and prod asset builds (with npm run) #34836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdmccormick merged 1 commit into from
May 22, 2024
Merged

test: check both dev and prod asset builds (with npm run) #34836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/static-assets-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,21 +68,39 @@ jobs:
key: ${{ runner.os }}-pip-${{ hashFiles('requirements/edx/development.txt') }}
restore-keys: ${{ runner.os }}-pip-

- name: Install Required Python Dependencies
- name: Install Limited Python Deps for Build
run: |
make base-requirements
pip install -r requirements/edx/assets.txt

- name: Initiate Mongo DB Service
run: sudo systemctl start mongod

- name: Add node_modules bin to $Path
run: echo $GITHUB_WORKSPACE/node_modules/.bin >> $GITHUB_PATH

- name: Run Static Assets Check
- name: Check Dev Assets Build
env:
COMPREHENSIVE_THEMES_DIR: ./themes
run: |
npm clean-install --dev
npm run build-dev

- name: Check Prod Assets Build
env:
COMPREHENSIVE_THEMES_DIR: ./themes
run: |
npm clean-install
npm run build

- name: Install Full Python Deps for Collection
run: |
pip install -r requirements/edx/base.txt -e .

- name: Check Assets Collection
env:
LMS_CFG: lms/envs/minimal.yml
CMS_CFG: lms/envs/minimal.yml

DJANGO_SETTINGS_MODULE: lms.envs.production
run: |
paver update_assets lms --theme-dirs ./themes
paver update_assets cms --theme-dirs ./themes
./manage.py lms collectstatic --noinput
./manage.py cms collectstatic --noinput
2 changes: 1 addition & 1 deletion docs/references/static-assets.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ skip this section.
First, ensure you have a Python enironment with all edx-platform dependencies
installed::

pip install -r requirements/edx/base.txt
pip install -r requirements/edx/base.txt -e .

Next, download localized versions of edx-platform assets. Under the hood, this
command uses the `Open edX Atlas`_ tool, which manages aggregated translations
Expand Down