Skip to content

chore: remove outdated JWT auth related settings #37373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 1 commit into from
Sep 22, 2025
Merged

chore: remove outdated JWT auth related settings #37373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cms/envs/mock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,6 @@ STORAGES:
BACKEND: openedx.core.storage.ProductionStorage
DEFAULT_FROM_EMAIL: no-reply@registration.localhost
DEFAULT_HASHING_ALGORITHM: sha256
DEFAULT_JWT_ISSUER:
AUDIENCE: test_password
ISSUER: https://courses.localhost/oauth2
SECRET_KEY: test_secret_key
DEFAULT_SITE_THEME: localhost
DISABLED_COUNTRIES:
- US
Expand Down Expand Up @@ -513,7 +509,6 @@ JWT_AUTH:
"kid": "lms001"}]}'
JWT_SECRET_KEY: test_JWT_SECRET_KEY
JWT_SIGNING_ALGORITHM: RS512
JWT_ISSUER: https://courses.localhost/oauth2
LANGUAGE_COOKIE: language-preference
LEARNER_PORTAL_URL_ROOT: https://masters.localhost
LEARNER_RECORD_MICROFRONTEND_URL: https://records.localhost
Expand Down
7 changes: 0 additions & 7 deletions lms/envs/mock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,6 @@ STORAGES:
BACKEND: openedx.core.storage.ProductionStorage
DEFAULT_FROM_EMAIL: sandbox-notifications@example.com
DEFAULT_HASHING_ALGORITHM: sha256
DEFAULT_JWT_ISSUER:
AUDIENCE: SET-ME-PLEASE
ISSUER: https://deploy_host/oauth2
SECRET_KEY: SET-ME-PLEASE
DEFAULT_MOBILE_AVAILABLE: true
DEFAULT_NOTIFICATION_ICON_URL: https://notifications-static.localhost/icons/post_outline.png
DEFAULT_SITE_THEME: localhost
Expand Down Expand Up @@ -725,9 +721,6 @@ JWT_AUTH:
JWT_SECRET_KEY: SET-ME-PLEASE
JWT_SIGNING_ALGORITHM: null
JWT_AUTH_ADD_KID_HEADER: true
JWT_EXPIRATION: 30
JWT_ISSUER: https://deploy_host/oauth2
JWT_PRIVATE_SIGNING_KEY: null
LANGUAGE_CODE: en
LANGUAGE_COOKIE: openedx-language-preference
LEARNER_DASHBOARD_AMPLITUDE_MODEL_ID: hello
Expand Down
13 changes: 0 additions & 13 deletions openedx/envs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,19 +612,6 @@ def _make_locale_paths(settings):
'JWT_AUTH_HEADER_PREFIX': 'JWT',
}

# These JWT settings appear to be vestigial. They are duplicates of settings
# defined in JWT_AUTH above, and don't seem to be used anymore. See issue
# https://github.com/openedx/edx-drf-extensions/issues/332.
JWT_ISSUER = 'http://127.0.0.1:8000/oauth2'
DEFAULT_JWT_ISSUER = {
'ISSUER': 'http://127.0.0.1:8000/oauth2',
'AUDIENCE': 'SET-ME-PLEASE',
'SECRET_KEY': 'SET-ME-PLEASE'
}
JWT_EXPIRATION = 30
JWT_PRIVATE_SIGNING_KEY = None


################################# Features #################################

# .. setting_name: PLATFORM_NAME
Expand Down
Loading