Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/verify transifex gh app 2 way sync #29

Closed
brian-smith-tcril opened this issue Nov 14, 2022 · 2 comments
Closed

test/verify transifex gh app 2 way sync #29

brian-smith-tcril opened this issue Nov 14, 2022 · 2 comments
Assignees

Comments

@brian-smith-tcril
Copy link
Contributor

the transifex gh app supports 2 way sync, with the strings in this repo as the source of truth in merge conflicts. it'd be good to have a solid, tested, understanding of this behavior

one example i'd like to test is:

  • we have 20 strings in a file
  • one is updated in the repo
  • 20 are updated in transifex
  • sync is run

is the app smart enough to resolve conflicts there by only syncing the one string up to transifex? or do all the new translations in transifex get wiped by the sync?

@brian-smith-tcril
Copy link
Contributor Author

there has been discussion on OEP-58 about if this is a good idea or not

one argument for keeping 2 way sync is for fixing format variable issues that aren't caught in transifex, but simply updating the strings in transifex when those issues are found has been proposed as an alternative solution

@brian-smith-tcril
Copy link
Contributor Author

based on transifex docs https://help.transifex.com/en/articles/6265125-github-via-transifex-ui

For existing resources that have already been synced with GitHub, if translations are found in GitHub, they will be sent to Transifex only if no translations are found for that language in Transifex

knowing this, it seems we should stick to the idea of transifex as a source of truth for all translated strings, and any updates should happen in transifex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant