fix: avoid infinite while loop with colorYiq
#2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
force-pushed
the
ags/yiq-auto-darken-brighten-until-a11y
branch
from
6a8b5a6
to
d9144cb
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## alpha #2349 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 214 214
Lines 3519 3519
Branches 852 852
=======================================
Hits 3223 3223
Misses 288 288
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 21.0.0-alpha.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
monteri
pushed a commit
to raccoongang/paragon
that referenced
this pull request
Aug 17, 2023
* fix: avoid never ending while loop with colorYiq * fix: replace scss variable with css variable
PKulkoRaccoonGang
pushed a commit
to raccoongang/paragon
that referenced
this pull request
Aug 18, 2023
* fix: avoid never ending while loop with colorYiq * fix: replace scss variable with css variable
|
🎉 This PR is included in version 22.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 1, 2024
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 4, 2024
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 4, 2024
PKulkoRaccoonGang
pushed a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running the updated
colorYiqfunction that tries to automatically darken/brighten color tokens if they do not pass background/foreground color contrast ratio of 4.5:1 for a11y hits an infinite loop if the colors can never meet a 4.5:1 contrast ratio.This PR ensures we only try to brighten/darken tokens a max of 10 times to avoid an infinite loop. Consoles a warning with the design token name when it couldn't brighten/darken tokens sufficiently to pass a 4.5:1 contrast ratio.
Deploy Preview
N/A
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist