Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move on from deprecated pkg_resources api #81

Closed
farhan opened this issue Aug 26, 2024 · 3 comments · Fixed by #123
Closed

Move on from deprecated pkg_resources api #81

farhan opened this issue Aug 26, 2024 · 3 comments · Fixed by #123
Assignees
@bmtcril
Labels
Aspects 2.0 maintenance Routine upkeep necessary for the health of the platform

Comments

@farhan
Copy link

farhan commented Aug 26, 2024

Shift the code from pkg_resources to importlib.resources api

Migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html
Decision making story: openedx/XBlock#676
Reference PR to take learning from: https://github.com/openedx/xblock-sdk/pull/350/files

Prerequisites:

Acceptance Criteria:

  • Make sure the repository is using xblock version 5.0.0 or above. Upgrade the version if required, preferably via the make upgrade command.
  • There should be no usage of pkg_resources in the repository
  • Test cases should be passed
  • XBlock should perform all of its functionality related to change (loading resources)
@farhan farhan added the maintenance Routine upkeep necessary for the health of the platform label Aug 26, 2024
@farhan farhan mentioned this issue Aug 26, 2024
Closed
@bmtcril bmtcril moved this to Blocked in Data Working Group Sep 17, 2024
@bmtcril
Copy link
Contributor

bmtcril commented Sep 17, 2024

This is another one that's blocked until we do our Aspects v2 breaking changes, until then we still need to support 3.8 for named releases back to Nutmeg.

@bmtcril bmtcril moved this from Blocked to Ready for Work in Data Working Group Jan 22, 2025
@feanil
Copy link
Contributor

feanil commented Jan 23, 2025

@bmtcril is this still blocked or can we start work on it?

@bmtcril
Copy link
Contributor

bmtcril commented Jan 23, 2025

@feanil yep, it's part of the breaking changes for Aspects 2.0 that I pulled together for scheduling yesterday: https://github.com/orgs/openedx/projects/5/views/12 We should be starting on those tasks this week or next.

@bmtcril bmtcril self-assigned this Jan 23, 2025
@bmtcril bmtcril moved this from Ready for Work to Doing in Data Working Group Jan 23, 2025
@bmtcril bmtcril mentioned this issue Jan 24, 2025
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from Doing to Done in Data Working Group Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmtcril bmtcril

Labels
Aspects 2.0 maintenance Routine upkeep necessary for the health of the platform
Projects
Data Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove remaining Python 3.8 compatibility openedx/platform-plugin-aspects
3 participants
@feanil @farhan @bmtcril