Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in sqlacodegen's defs #21

Closed
nesnoj opened this issue Jun 8, 2017 · 7 comments
Closed

fix bugs in sqlacodegen's defs #21

nesnoj opened this issue Jun 8, 2017 · 7 comments
Labels
Milestone

Comments

@nesnoj
Copy link
Member

nesnoj commented Jun 8, 2017

See no. 3.-6. in wiki.
@MGlauer Have you got any hints on this?

@nesnoj nesnoj added the bug label Jun 8, 2017
@nesnoj nesnoj added this to the Release 0.3 milestone Jun 8, 2017
This was referenced Jun 8, 2017
@MGlauer
Copy link
Member

MGlauer commented Jun 8, 2017

  1. Ok, i took the time to read through the sqlacodegen code. By default, tailing s letters are considered as plurals and inflected (i.e. the s is cropped). This can be prevented by the parameter --noinflect (but this might affect other tables, too)

@MGlauer
Copy link
Member

MGlauer commented Jun 8, 2017

  1. These types should not exist at all in the python code. they are translated (e.g. double precision -> Float). But this seems to be broken for Arrays. I opened a bug report

@MGlauer
Copy link
Member

MGlauer commented Jun 8, 2017

  1. I guess there is no way to fix this other than renaming the column

@nesnoj
Copy link
Member Author

nesnoj commented Jun 9, 2017

Wow, tanks for your efforts! 👍

Concerning
3. We wait for an answer, they might fix it (or use your fork :)
4. openego/data_processing#102
5. sqlacodegen seems to use engine.singular_noun() from inflect (e.g. here) only to remove plural from last word of table name. As the *Bus-tables are the only ones who show this problem, I actually guess that no other tables will be affected. So for the next release I'd give it a try with the --noinflect option...

@Ludee
Copy link
Member

Ludee commented Jun 19, 2017

metadata/meta_data is fixed!

@nesnoj
Copy link
Member Author

nesnoj commented Jun 19, 2017

Thx! I adjusted the wiki.

@gplssm
Copy link
Contributor

gplssm commented Jan 17, 2018

As this is quite old and maybe outdated, I close. Please open a new issue if problems arise with upcoming releases.

@gplssm gplssm closed this as completed Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants