Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-engineio: now depends on simple-websocket #856

Open
FederAndInk opened this issue Aug 5, 2024 · 2 comments
Open

python3-engineio: now depends on simple-websocket #856

FederAndInk opened this issue Aug 5, 2024 · 2 comments

Comments

@FederAndInk
Copy link

engineio now depends on simple-websocket since version 4.7.1
it doesn't seem to be specified in the recipe.

https://github.com/miguelgrinberg/python-engineio/blob/main/pyproject.toml#L14

@ycongal-smile
Copy link
Contributor

I'll look into this

@ycongal-smile
Copy link
Contributor

engineio now depends on simple-websocket since version 4.7.1 it doesn't seem to be specified in the recipe.

https://github.com/miguelgrinberg/python-engineio/blob/main/pyproject.toml#L14

I've looked at the code a little bit. It seems that the simple-websocket dependencies is as optional as request or websocket-client. ie without it, you can still run the package in other modes (client or server, gevent or something else...)

Maybe you can:

  1. ask the python-engineio project if simple-websocket is really a required dependency or an optional one.
  2. put the optional dependencies (simple-websocket, request, websocket-client) behind PACKAGECONFIG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants