Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Performance degression on Kovan #10230

Closed
5chdn opened this issue Jan 22, 2019 · 10 comments · Fixed by #10305
Closed

Performance degression on Kovan #10230

5chdn opened this issue Jan 22, 2019 · 10 comments · Fixed by #10305
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Milestone

Comments

@5chdn
Copy link
Contributor

5chdn commented Jan 22, 2019

  • Parity Ethereum version: 2.3.0
  • Operating system: Linux
  • Installation: auto-updater
  • Fully synchronized: yes
  • Network: kovan
  • Restarted: yes
 > tac parity-error-1.log | grep Starting
2019-01-16 01:08 +00:00: 2019-01-16 01:08:51 UTC Starting Parity-Ethereum/v2.3.0-beta-10657d9-20190115/x86_64-linux-gnu/rustc1.31.1
2018-12-25 19:11 +00:00: 2018-12-25 19:11:07 UTC Starting Parity-Ethereum/v2.2.5-beta-7fbcdfe-20181213/x86_64-linux-gnu/rustc1.31.0

After upgrading from 2.2.5 to 2.3.0 on Kovan, the following happened:

screenshot from 2019-01-22 13-55-51

@5chdn 5chdn added P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. labels Jan 22, 2019
@5chdn 5chdn added this to the 2.4 milestone Jan 22, 2019
@ddorgan
Copy link
Collaborator

ddorgan commented Jan 22, 2019

There's also a large increase in bandwidth usage, Terabytes of traffic...:

image

@ddorgan
Copy link
Collaborator

ddorgan commented Jan 22, 2019

@5chdn did you not see this on your QA systems?

@5chdn
Copy link
Contributor Author

5chdn commented Jan 22, 2019

I was fairly busy this week. Good thing @fevo1971 spotted this

@TriplEight
Copy link
Collaborator

that would be unbelievable if the discovery system is the cause.

@ddorgan
Copy link
Collaborator

ddorgan commented Jan 22, 2019

It's pretty strange because the main net bootnodes don't seem to have the same issue....

@5chdn 5chdn added Z5-intended 🎯 Issue describes a behavior which turns out to work as intended. Closer should explain why. and removed F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Jan 22, 2019
@jam10o-new
Copy link
Contributor

Since this appears to be appearing from 2.2.7 and 2.3.0 it is almost certainly caused by #10167 - if a node is on a more sparse network (testnets/private nets), the bandwidth usage seems to be much higher - due to discovery pings maybe?

@teodor-pripoae
Copy link

Hi, I'm having the same issue on kovan network. I've upgraded on 17 January from v2.1.6 to v2.2.7. Traffic increased to terrabytes, it costs hundreds of dollars in the cloud.

On mainnet running the same version it uses max 500kb/s.

On kovan:

screenshot 2019-02-04 14 55 57

screenshot 2019-02-04 15 08 02

On mainnet:

screenshot 2019-02-04 15 11 31

screenshot 2019-02-04 15 14 11

@teodor-pripoae
Copy link

Downgrading to 2.2.6 solved the problem so I think the regression was introduced in 2.2.7.

screenshot 2019-02-04 15 40 45

@petehall73
Copy link

Hi @5chdn, I see you removed the P2 tag on this bug. I'm not sure that's correct. I understand that this is as a result of the security patch but the massive increase in traffic is a huge problem for anyone hosting a node in the cloud and is billed for outbound network traffic. I'm managing the situation by restricting peers and pending peers but that's merely a workaround. I'd like to see this given a higher priority as it would force me to seek alternatives.

@ddorgan
Copy link
Collaborator

ddorgan commented Feb 5, 2019

@petehall73 somebody is working on fix on this, an update will be posted here once it's ready and tested.

@5chdn 5chdn added P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. and removed Z5-intended 🎯 Issue describes a behavior which turns out to work as intended. Closer should explain why. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants