Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Swift shutdown #3332

Closed
arkpar opened this issue Nov 10, 2016 · 4 comments
Closed

Swift shutdown #3332

arkpar opened this issue Nov 10, 2016 · 4 comments
Assignees
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q5-substantial 📓 Can be fixed by a developer with decent experience.
Milestone

Comments

@arkpar
Copy link
Collaborator

arkpar commented Nov 10, 2016

Ctrl-C should result in faster program exit when syncing.

  • import_verified_blocks should check exit condition for every block
  • Snapshot restoration should check exit condition for every item (i.e. block or state account)
@arkpar arkpar added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q5-substantial 📓 Can be fixed by a developer with decent experience. labels Nov 10, 2016
@rphmeier
Copy link
Contributor

second point adressed in #3356

@5chdn
Copy link
Contributor

5chdn commented May 10, 2017

This issue is labelled with sometimesoon: Issue is worth doing soon; and annoyance: The client behaves within expectations, however this "expected behaviour" itself is at issue. But it's inactive for more than 6 months and neither assigned nor linked to a milestone.

@paritytech/core-devs Please, review this issue within 7 days. It probably needs a re-prioritization, or a proper deadline and an assignee.

@rphmeier
Copy link
Contributor

Slow NAT detection also an issue, reported by @tomusdrw in #4321:

 $ ./target/release/parity
2017-01-27 09:15:24  main INFO parity::run  Starting Parity/v1.6.0-unstable-f9eb13b-20170124/x86_64-linux-gnu/rustc1.16.0-nightly
2017-01-27 09:15:24  main INFO parity::run  State DB configuration: fast
2017-01-27 09:15:24  main INFO parity::run  Operating mode: active
2017-01-27 09:15:24  main INFO ethcore::service  Configured for Ropsten using Ethash engine
2017-01-27 09:15:25  hyper-client INFO miner  Updated conversion rate to Ξ1 = US$10.49 (11348677000 wei/gas)
2017-01-27 09:15:33  IO Worker #1 INFO import  Syncing  #419016 3db9…32dd    170 blk/s  247 tx/s  65 Mgas/s     185+ 1006 Qed    #420221    7/ 7/25 peers    218 MiB db    1 MiB chain    6 MiB queue  798 KiB sync
^C2017-01-27 09:15:35  main INFO parity::run  Finishing work, please wait...
^C^C^Z
[1]+  Stopped                 ./target/release/parity
$ kill %1
$ kill -9 %1
[1]+  Killed                  ./target/release/parity

It should close fast without waiting for enode line to be printed

@arkpar arkpar self-assigned this May 10, 2017
@arkpar arkpar added this to the 1.7 milestone May 10, 2017
@5chdn 5chdn modified the milestones: 1.8, 1.9 Oct 12, 2017
@5chdn 5chdn modified the milestones: 1.9, 1.10 Jan 5, 2018
@5chdn 5chdn modified the milestones: 1.10, 1.11 Jan 23, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@5chdn 5chdn modified the milestones: 1.12, 1.13 Apr 24, 2018
@folsen
Copy link
Contributor

folsen commented May 19, 2018

Closing, if there's any more specific blocker to slow shutdown time please open separate issue.

@folsen folsen closed this as completed May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon. Q5-substantial 📓 Can be fixed by a developer with decent experience.
Projects
None yet
Development

No branches or pull requests

4 participants