Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Dropping V62 peers #3624

Closed
zilm13 opened this issue Nov 25, 2016 · 4 comments
Closed

Dropping V62 peers #3624

zilm13 opened this issue Nov 25, 2016 · 4 comments
Labels
M4-core ⛓ Core client code / Rust. Z1-question 🙋‍♀️ Issue is a question. Closer should answer.

Comments

@zilm13
Copy link

zilm13 commented Nov 25, 2016

Hello, you are currently dropping incoming connections from V62 peers while you supported them some time ago.
I guess, these lines are the reason of it https://github.com/ethcore/parity/blob/master/sync/src/chain.rs#L610-L614
Could you return support for V62 peers?

@arkpar
Copy link
Collaborator

arkpar commented Nov 25, 2016

We don't want maintain code for old protocol version unless there's a good reason for it. Why do you think we should support it?

@zilm13
Copy link
Author

zilm13 commented Nov 25, 2016

@arkpar V62 is not deprecated officially and V62 nodes are still useful for you on short sync, for headers, block bodies etc.

@gavofyork
Copy link
Contributor

What counts as "officially"? :-)

@tomusdrw tomusdrw added M4-core ⛓ Core client code / Rust. Z1-question 🙋‍♀️ Issue is a question. Closer should answer. labels Nov 27, 2016
@Nashatyrev
Copy link

Hey guys!
We just want to understand the reasons behind dropping the peer which declares only eth62 supported. It doesn't differ from the scenario when the peer declares eth62,eth63 and uses only eth62 (as far as I know Parity supports eth63 in 'passive' mode only)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M4-core ⛓ Core client code / Rust. Z1-question 🙋‍♀️ Issue is a question. Closer should answer.
Projects
None yet
Development

No branches or pull requests

5 participants