Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Rename light::request::Requests to Batch #5413

Closed
rphmeier opened this issue Apr 6, 2017 · 5 comments
Closed

Rename light::request::Requests to Batch #5413

rphmeier opened this issue Apr 6, 2017 · 5 comments
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Apr 6, 2017

...and move it and the builder into a "batch" module.

"Batch" conveys the role of the structure w.r.t. partially handling responses much better.

@rphmeier rphmeier added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Apr 6, 2017
@5chdn
Copy link
Contributor

5chdn commented May 10, 2017

This issue is labelled with annoyance: The client behaves within expectations, however this "expected behaviour" itself is at issue. It's neither assigned nor linked to any milestone.

@paritytech/core-devs Please decide on a deadline and add an assignee within 7 days, thanks!

@rphmeier rphmeier added F6-refactor 📚 Code needs refactoring. and removed F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. labels May 10, 2017
@5chdn 5chdn added the P7-nicetohave 🐕 Issue is worth doing eventually. label Sep 4, 2017
@asymmetric
Copy link
Contributor

Interested in taking this. Should RequestBuilder become BatchBuilder?

Also, where should the newly created batch module live?

@rphmeier
Copy link
Contributor Author

@asymmetric it could just be called Builder since it can be referenced with batch::Builder. The batch module should live where the "builder" module does now, so essentially just a file and type rename.

@asymmetric
Copy link
Contributor

I'm working on this so I'd be happy to be assigned :)

@rphmeier
Copy link
Contributor Author

thanks and noted, but unfortunately we can't assign issues to people outside the organization :(

@debris debris assigned debris and unassigned debris Sep 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

4 participants