Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

eth_subscribe with no params crashed parity #6262

Closed
debris opened this issue Aug 9, 2017 · 0 comments · Fixed by #6264
Closed

eth_subscribe with no params crashed parity #6262

debris opened this issue Aug 9, 2017 · 0 comments · Fixed by #6264
Labels
F1-panic 🔨 The client panics and exits without proper error handling. M4-core ⛓ Core client code / Rust.

Comments

@debris
Copy link
Collaborator

debris commented Aug 9, 2017

I'm running:

  • Parity version: Parity/v1.8.0-unstable
  • Operating system: MacOS
  • And installed: from source
wscat -c 127.0.0.1:8546
> {"method": "eth_subscribe", "params":[], "id": 1, "jsonrpc":"2.0"}
disconnected

parity logs:

====================

stack backtrace:
   0:        0x1073b01c4 - backtrace::backtrace::trace<closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.2/src/backtrace/mod.rs:42
   1:        0x1073b056f - backtrace::capture::Backtrace::new::h92218407e8745e0e
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.2/src/capture.rs:64
   2:        0x1047a5963 - panic_hook::panic_hook
                        at panic_hook/src/lib.rs:53
   3:        0x1047a3e78 - core::ops::Fn::call<fn(&std::panicking::PanicInfo),(&std::panicking::PanicInfo)>
                        at /Users/travis/build/rust-lang/rust/src/libcore/ops.rs:2588
   4:        0x107415ee6 - std::panicking::rust_panic_with_hook::h8b9b25777425677b
                        at src/libstd/panicking.rs:550
   5:        0x107415d44 - std::panicking::begin_panic<collections::string::String>
                        at src/libstd/panicking.rs:511
   6:        0x107415cb2 - std::panicking::begin_panic_fmt::haf8695bfb6c52436
                        at src/libstd/panicking.rs:495
   7:        0x107415c17 - rust_begin_unwind
                        at src/libstd/panicking.rs:471
   8:        0x10743d610 - core::panicking::panic_fmt::hfedd6515bcee8bb1
                        at src/libcore/panicking.rs:69
   9:        0x10743d514 - core::panicking::panic::hd25e89dc434847c1
                        at src/libcore/panicking.rs:49
  10:        0x103c06986 - jsonrpc_macros::auto_args::{{impl}}::wrap_rpc<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>,parity_rpc::v1::metadata::Metadata,parity_rpc::v1::types::pubsub::Result,parity_rpc::v1::types::pubsub::Kind,parity_rpc::v1::types::pubsub::Params>
                        at /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/macros/src/auto_args.rs:593
  11:        0x1039df973 - parity_rpc::v1::traits::eth_pubsub::EthPubSub::to_delegate::{{closure}}<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>>
                        at /Users/marek/projects/ethcore/parity/<build_rpc_trait macros>:91
  12:        0x103b696b2 - jsonrpc_macros::delegates::{{impl}}::call<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>,parity_rpc::v1::metadata::Metadata,closure>
                        at /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/macros/src/delegates.rs:92
  13:        0x103a9949c - jsonrpc_pubsub::subscription::{{impl}}::call<parity_rpc::v1::metadata::Metadata,jsonrpc_macros::delegates::DelegateSubscribe<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>, closure>,jsonrpc_macros::delegates::DelegateUnsubscribe<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>, closure>>
                        at /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/pubsub/src/subscription.rs:220
  14:        0x1043030a3 - jsonrpc_macros::delegates::{{impl}}::add_subscription::{{closure}}<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>,parity_rpc::v1::metadata::Metadata,closure,closure>
                        at /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/macros/src/delegates.rs:218
  15:        0x103b2bb2e - jsonrpc_macros::delegates::{{impl}}::call<parity_rpc::v1::impls::eth_pubsub::EthPubSubClient<ethcore::client::client::Client>,parity_rpc::v1::metadata::Metadata,closure>
                        at /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/macros/src/delegates.rs:59
  16:        0x104209100 - jsonrpc_core::io::{{impl}}::handle_call::{{closure}}::{{closure}}<parity_rpc::v1::metadata::Metadata,(parity_rpc::v1::extractors::WsDispatcher<parity_rpc::v1::informant::Middleware<parity_rpc::v1::informant::ClientNotifier>>, parity_rpc::v1::informant::Middleware<parity_rpc::v1::informant::ClientNotifier>)>
                        at /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/core/src/io.rs:223
  17:        0x1041e9c10 - futures::future::lazy::{{impl}}::get<closure,alloc::boxed::Box<Future>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/lazy.rs:64
  18:        0x1045673ea - futures::future::lazy::{{impl}}::poll<closure,alloc::boxed::Box<Future>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/lazy.rs:82
  19:        0x10431c39e - futures::future::chain::{{impl}}::poll<futures::future::lazy::Lazy<closure, alloc::boxed::Box<Future>>,futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>,closure,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/chain.rs:26
  20:        0x104630db3 - futures::future::then::{{impl}}::poll<futures::future::lazy::Lazy<closure, alloc::boxed::Box<Future>>,futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/then.rs:32
  21:        0x1043870d6 - futures::future::{{impl}}::poll<Future>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/mod.rs:106
  22:        0x1045b0645 - futures::future::either::{{impl}}::poll<alloc::boxed::Box<Future>,futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/either.rs:35
  23:        0x10455e9e6 - futures::future::map::{{impl}}::poll<core::option::Option<jsonrpc_core::types::response::Response>,futures::future::either::Either<alloc::boxed::Box<Future>, futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/map.rs:30
  24:        0x1045b0945 - futures::future::either::{{impl}}::poll<futures::future::map::Map<futures::future::either::Either<alloc::boxed::Box<Future>, futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>>, closure>,futures::future::map::Map<futures::future::join_all::JoinAll<collections::vec::Vec<futures::future::either::Either<alloc::boxed::Box<Future>, futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>>>>, closure>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/either.rs:35
  25:        0x104556ef6 - futures::future::map::{{impl}}::poll<core::option::Option<jsonrpc_core::types::response::Response>,futures::future::either::Either<futures::future::map::Map<futures::future::either::Either<alloc::boxed::Box<Future>, futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>>, closure>, futures::future::map::Map<futures::future::join_all::JoinAll<collections::vec::Vec<futures::future::either::Either<alloc::boxed::Box<Future>, futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Output>, ()>>>>, closure>>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/map.rs:30
  26:        0x1043872b6 - futures::future::{{impl}}::poll<Future>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/mod.rs:106
  27:        0x1045b07e0 - futures::future::either::{{impl}}::poll<futures_cpupool::CpuFuture<core::option::Option<jsonrpc_core::types::response::Response>, ()>,alloc::boxed::Box<Future>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/either.rs:36
  28:        0x1043872b6 - futures::future::{{impl}}::poll<Future>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/mod.rs:106
  29:        0x1045b0760 - futures::future::either::{{impl}}::poll<futures::future::either::Either<futures_cpupool::CpuFuture<core::option::Option<jsonrpc_core::types::response::Response>, ()>, alloc::boxed::Box<Future>>,alloc::boxed::Box<Future>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/either.rs:36
  30:        0x1045b05e0 - futures::future::either::{{impl}}::poll<futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Response>, ()>,futures::future::either::Either<futures::future::either::Either<futures_cpupool::CpuFuture<core::option::Option<jsonrpc_core::types::response::Response>, ()>, alloc::boxed::Box<Future>>, alloc::boxed::Box<Future>>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/either.rs:36
  31:        0x104551976 - futures::future::map::{{impl}}::poll<core::option::Option<collections::string::String>,futures::future::either::Either<futures::future::result_::FutureResult<core::option::Option<jsonrpc_core::types::response::Response>, ()>, futures::future::either::Either<futures::future::either::Either<futures_cpupool::CpuFuture<core::option::Option<jsonrpc_core::types::response::Response>, ()>, alloc::boxed::Box<Future>>, alloc::boxed::Box<Future>>>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/map.rs:30
  32:        0x1043874e6 - futures::future::{{impl}}::poll<Future>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/mod.rs:106
  33:        0x104555d85 - futures::future::map::{{impl}}::poll<(),alloc::boxed::Box<Future>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/map.rs:30
  34:        0x1045b234f - futures::future::select::{{impl}}::poll<futures::future::map::Map<alloc::boxed::Box<Future>, closure>,jsonrpc_ws_server::session::LivenessPoll>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/select.rs:48
  35:        0x10454f646 - futures::future::map::{{impl}}::poll<(),futures::future::select::Select<futures::future::map::Map<alloc::boxed::Box<Future>, closure>, jsonrpc_ws_server::session::LivenessPoll>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/map.rs:30
  36:        0x1045c82b5 - futures::future::map_err::{{impl}}::poll<(),futures::future::map::Map<futures::future::select::Select<futures::future::map::Map<alloc::boxed::Box<Future>, closure>, jsonrpc_ws_server::session::LivenessPoll>, closure>,closure>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/map_err.rs:30
  37:        0x1066a937f - futures::future::{{impl}}::poll<Future>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/future/mod.rs:106
  38:        0x106696a3c - futures::task_impl::{{impl}}::poll_future::{{closure}}<alloc::boxed::Box<Future>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/task_impl/mod.rs:337
  39:        0x106696d6f - futures::task_impl::{{impl}}::enter::{{closure}}<alloc::boxed::Box<Future>,closure,core::result::Result<futures::poll::Async<()>, ()>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/task_impl/mod.rs:484
  40:        0x1066aacb5 - futures::task_impl::set::{{closure}}<closure,core::result::Result<futures::poll::Async<()>, ()>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/task_impl/mod.rs:61
  41:        0x106697d04 - std::thread::local::{{impl}}::with<core::cell::Cell<*const futures::task_impl::BorrowedTask>,closure,core::result::Result<futures::poll::Async<()>, ()>>
                        at /Users/travis/build/rust-lang/rust/src/libstd/thread/local.rs:265
  42:        0x1066aab3d - futures::task_impl::set<closure,core::result::Result<futures::poll::Async<()>, ()>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/task_impl/mod.rs:54
  43:        0x106696bbd - futures::task_impl::{{impl}}::enter<alloc::boxed::Box<Future>,closure,core::result::Result<futures::poll::Async<()>, ()>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/task_impl/mod.rs:484
  44:        0x1066969f2 - futures::task_impl::{{impl}}::poll_future<alloc::boxed::Box<Future>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-0.1.11/src/task_impl/mod.rs:337
  45:        0x1066b5666 - tokio_core::reactor::{{impl}}::dispatch_task::{{closure}}
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-core-0.1.6/src/reactor/mod.rs:366
  46:        0x1066926b9 - scoped_tls::{{impl}}::set<tokio_core::reactor::Core,closure,core::result::Result<futures::poll::Async<()>, ()>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/scoped-tls-0.1.0/src/lib.rs:135
  47:        0x1066b537f - tokio_core::reactor::{{impl}}::dispatch_task
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-core-0.1.6/src/reactor/mod.rs:366
  48:        0x1066b4b35 - tokio_core::reactor::{{impl}}::dispatch
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-core-0.1.6/src/reactor/mod.rs:324
  49:        0x1066b4748 - tokio_core::reactor::Core::poll::h43952d499d068722
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-core-0.1.6/src/reactor/mod.rs:312
  50:        0x1051f4efe - tokio_core::reactor::{{impl}}::run<futures::future::select::Select<futures::future::empty::Empty<(), futures::sync::oneshot::Canceled>, futures::sync::oneshot::Receiver<()>>>
                        at /Users/marek/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-core-0.1.6/src/reactor/mod.rs:249
  51:        0x10521aa3a - parity_reactor::{{impl}}::spawn::{{closure}}
                        at util/reactor/src/lib.rs:45
  52:        0x1051fa15a - std::sys_common::backtrace::__rust_begin_short_backtrace<closure,()>
                        at /Users/travis/build/rust-lang/rust/src/libstd/sys_common/backtrace.rs:136
  53:        0x1051fbd0a - std::thread::{{impl}}::spawn::{{closure}}::{{closure}}<closure,()>
                        at /Users/travis/build/rust-lang/rust/src/libstd/thread/mod.rs:364
  54:        0x105219bba - std::panic::{{impl}}::call_once<(),closure>
                        at /Users/travis/build/rust-lang/rust/src/libstd/panic.rs:296
  55:        0x1051fbfe7 - std::panicking::try::do_call<std::panic::AssertUnwindSafe<closure>,()>
                        at /Users/travis/build/rust-lang/rust/src/libstd/panicking.rs:454

Thread '<unnamed>' panicked at 'attempt to subtract with overflow', /Users/marek/.cargo/git/checkouts/jsonrpc-22a65938f7d26b63/4d3ec22/macros/src/auto_args.rs:593
@debris debris added F2-bug 🐞 The client fails to follow expected behavior. M4-core ⛓ Core client code / Rust. labels Aug 9, 2017
@debris debris added F1-panic 🔨 The client panics and exits without proper error handling. and removed F2-bug 🐞 The client fails to follow expected behavior. labels Aug 9, 2017
@debris debris mentioned this issue Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F1-panic 🔨 The client panics and exits without proper error handling. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant