Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Have network-specific critical flag for auto-updater #8392

Closed
tomusdrw opened this issue Apr 13, 2018 · 3 comments
Closed

Have network-specific critical flag for auto-updater #8392

tomusdrw opened this issue Apr 13, 2018 · 3 comments
Labels
F8-enhancement 🎊 An additional feature request. M1-ci 🙉 Continuous integration. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone

Comments

@tomusdrw
Copy link
Collaborator

Currently we have a single critical flag defined in util/version/Cargo.toml.
This is a pain if the update is critical on say kovan, but not on mainnet.

Instead we should store separate flags for each network and update https://github.com/paritytech/push-release to read those.

@tomusdrw tomusdrw added F8-enhancement 🎊 An additional feature request. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. M1-ci 🙉 Continuous integration. labels Apr 13, 2018
@Tbaut Tbaut added this to the 1.11 milestone Apr 13, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Apr 24, 2018
@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Jun 6, 2018

I'd bump priority on this one.

@ascjones
Copy link
Contributor

ascjones commented Jun 6, 2018

Should we aggregate network specific auto-updater settings e.g

[package.metadata.networks]
foundation = { forkBlock = 4370000, critical = false }
ropsten = { forkBlock = 10, critical = false }
kovan = { forkBlock = 6600000, critical = false }

or just add another section with critical flags for each network? Is the existing critical flag is only used by push-release?

@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Jun 6, 2018

  1. IMHO aggregate looks nicer.
  2. Critical is only used by push-release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M1-ci 🙉 Continuous integration. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

4 participants