Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

refactor parity-dapps-glue crate #8405

Closed
debris opened this issue Apr 14, 2018 · 7 comments
Closed

refactor parity-dapps-glue crate #8405

debris opened this issue Apr 14, 2018 · 7 comments
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@debris
Copy link
Collaborator

debris commented Apr 14, 2018

Currently parity-dapps-glue uses quasi, which is no longer maintained - serde-deprecated/quasi. Let's use refactor it to use proc-macro, syn and quote instead

cc @tomusdrw

@debris debris added F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. labels Apr 14, 2018
@5chdn 5chdn added this to the 1.13 milestone Apr 25, 2018
@5chdn 5chdn added the P7-nicetohave 🐕 Issue is worth doing eventually. label Apr 25, 2018
@folsen
Copy link
Contributor

folsen commented May 21, 2018

Closing because UI is moving.

@folsen folsen closed this as completed May 21, 2018
@sorpaas
Copy link
Collaborator

sorpaas commented Jun 26, 2018

I think we probably still need to keep this issue open for a while. Currently parity-dapps-glue crate is still in the code -- we would either need to remove it or do the refactoring described in this issue.

@sorpaas sorpaas reopened this Jun 26, 2018
@tomusdrw
Copy link
Collaborator

What is the glue still used for? As a workaround we can just hardcode the generated code instead of rewriting it.

@sorpaas
Copy link
Collaborator

sorpaas commented Jun 26, 2018

@tomusdrw For our current code we're only using the WebApp trait and Info struct. They're perfectly fine to be moved to parity-dapps crate. The only issue is that if someone wants to create a new builtin dapp (https://github.com/paritytech/parity/tree/master/dapps/js-glue) in a customized version of parity, they rely on the js-glue crate right now.

No matter what we do, this will eventually be fixed when Parity UI takes over all dapps functionalities and we should then be able to remove the js-glue crate.

@folsen
Copy link
Contributor

folsen commented Jun 27, 2018

Ping @axelchalon this might be something semi-related to what you're working on and of interest for you to look at?

@axelchalon
Copy link
Contributor

Hey, I don't think parity-dapps-glue is used for anything anymore. Built-in dapps are now completely handled by Parity UI.

I was thinking that as soon as the Parity UI network dapps PR is reviewed and merged, we can remove the whole dapps crate (incl. parity-dapps-glue) and dapps-related cli/config options in one fell swoop.

@axelchalon
Copy link
Contributor

parity-dapps-glue removed in #9017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F6-refactor 📚 Code needs refactoring. M4-core ⛓ Core client code / Rust. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

6 participants