Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Panic (deadlock) on Parity shutdown when using Tendermint engine #8804

Closed
debris opened this issue Jun 5, 2018 · 5 comments
Closed

Panic (deadlock) on Parity shutdown when using Tendermint engine #8804

debris opened this issue Jun 5, 2018 · 5 comments
Labels
F1-panic 🔨 The client panics and exits without proper error handling. M4-core ⛓ Core client code / Rust.
Milestone

Comments

@debris
Copy link
Collaborator

debris commented Jun 5, 2018

basically the same as #8088

@debris debris added M4-core ⛓ Core client code / Rust. F1-panic 🔨 The client panics and exits without proper error handling. labels Jun 5, 2018
@debris
Copy link
Collaborator Author

debris commented Jun 6, 2018

This case is actually slightly more complicated than #8088 . TransitionHandler from engines/transition.rs is generic over Engine<Machine>. The ideal solution would be one of the following:

a) internal refactor of out event loop
b) injecting event loop to an engine, so an engine never has an ownership of event loop (it shouldn't imo)
c) decoupling step logic from engine (I don't know if it's possible)

@5chdn 5chdn added this to the 1.12 milestone Jun 6, 2018
@5chdn
Copy link
Contributor

5chdn commented Jun 23, 2018

#8664 :)

@5chdn 5chdn modified the milestones: 2.0, 2.1 Jul 17, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@Tbaut
Copy link
Contributor

Tbaut commented Nov 14, 2018

Closing because of #8664 :)

@Tbaut Tbaut closed this as completed Nov 14, 2018
@debris
Copy link
Collaborator Author

debris commented Nov 26, 2018

I don't think it should be closed. The issue exists in current version and we don't have substrate PoC-1 implementation yet. And there is no guarantee that substrate PoC-1 implementation is not built as an alteration of tendermint engine and it does not have the same issue

@debris debris reopened this Nov 26, 2018
@Tbaut
Copy link
Contributor

Tbaut commented Nov 28, 2018

I really think this issue is not worth investing time on it. Also #9980 totally removed Tendermint from Parity Ethereum.

@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.5, 2.6 Apr 2, 2019
@dvdplm dvdplm closed this as completed Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F1-panic 🔨 The client panics and exits without proper error handling. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

No branches or pull requests

5 participants