Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Refactor on-demand queries to use failsafe-rs #9536

Closed
2 tasks
ordian opened this issue Sep 12, 2018 · 0 comments · Fixed by #9790
Closed
2 tasks

Refactor on-demand queries to use failsafe-rs #9536

ordian opened this issue Sep 12, 2018 · 0 comments · Fixed by #9790
Assignees
@niklasad1
Labels
F6-refactor 📚 Code needs refactoring. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone
2.4

Comments

@ordian
Copy link
Member

ordian commented Sep 12, 2018 •
edited
Loading

See #9318 (comment).
Other things worth doing:

  • Use wrapping adds where possible
  • The logic in dispatch_pending is quite complex. It would be nice to extract some functions to reduce cyclomatic complexity.
@ordian ordian added F6-refactor 📚 Code needs refactoring. P7-nicetohave 🐕 Issue is worth doing eventually. labels Sep 12, 2018
@ordian ordian changed the title Refactor on-demand quieries to use failsafe-rs Refactor on-demand queries to use failsafe-rs Sep 12, 2018
@5chdn 5chdn added this to the 2.3 milestone Sep 27, 2018
@niklasad1 niklasad1 self-assigned this Oct 16, 2018
@niklasad1 niklasad1 mentioned this issue Oct 21, 2018
Merged
@5chdn 5chdn modified the milestones: 2.3, 2.4 Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@niklasad1 niklasad1

Labels
F6-refactor 📚 Code needs refactoring. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

light client : failsafe crate (circuit breaker) openethereum/parity-ethereum
3 participants
@ordian @niklasad1 @5chdn