Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shut-down logic for subscriber/publisher #51

Open
alexellis opened this issue Jan 15, 2019 · 3 comments
Open

Add shut-down logic for subscriber/publisher #51

alexellis opened this issue Jan 15, 2019 · 3 comments
Assignees

Comments

@alexellis
Copy link
Member

Expected Behaviour

The subscriber (queue-worker) and publisher (gateway) should not try to reconnect if the connection is being broken due to SIGTERM/SIGINT.

Current Behaviour

Once #50 is merged they should both try to re-try during the period at which they are terminating.

Possible Solution

The watchdog implements similar logic, it could probably be adapted for use here: https://github.com/openfaas/faas/blob/master/watchdog/main.go#L86

@bartsmykla
Copy link
Contributor

Derek assign: me

@bartsmykla
Copy link
Contributor

I want to do that. It should be quick thing

@embano1
Copy link

embano1 commented Dec 15, 2019

@bartsmykla has this been resolved with your PR so this issue can be closed? Thx for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants