Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated methods #22

Open
3 tasks
rhamzeh opened this issue Jun 14, 2024 · 3 comments
Open
3 tasks

Stop using deprecated methods #22

rhamzeh opened this issue Jun 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Jun 14, 2024

  • Deprecated method TextFieldWithBrowseButton.addBrowseFolderListener(...) is invoked in OpenFGASettingsComponent.<init>(). This method will be removed in a future release
  • Deprecated constructor TemplateContextType.<init>(String, String) is invoked in OpenFGATemplateContext.<init>()
  • Deprecated field ModalityState.NON_MODAL is accessed in DslToJsonTask.onSuccess(File, File)
Image
@rhamzeh rhamzeh added the bug Something isn't working label Jun 14, 2024
@rhamzeh rhamzeh moved this from Backlog to Ready in SDKs and Tooling Jun 18, 2024
@Akshayp02
Copy link

Hello @rhamzeh ,

I would like to contribute to this issue. Could you please assign it to me and provide any relevant references or guidance?

Thank you!

@ewanharris
Copy link
Member

👋🏻 Thanks for the interest in picking this up @Akshayp02. There's two deprecations that need fixing.

  • Our usage of the constructor for TemplateContextType here
    • The "OPENFGA_CONTEXT string needs to be removed and moved to the plugin.xml file as stated in the docs here.
    • It looks like we already set that so it might just need removing from the super call.
  • Our usage of ModalityState.NON_MODAL here needs replacing with the recommended replacement.

I'll assign this task to you and please feel free to ping me if you need any assistance.

@ewanharris
Copy link
Member

Hey @Akshayp02 I just wanted to check in an see how you're getting on with this change, is there any assistance I can provide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

3 participants