Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account input declared for several months #841

Closed
fpagnoux opened this issue Mar 14, 2019 · 2 comments
Closed

Take into account input declared for several months #841

fpagnoux opened this issue Mar 14, 2019 · 2 comments
Assignees
@fpagnoux

Comments

@fpagnoux
Copy link
Member

fpagnoux commented Mar 14, 2019 •
edited by sandcha
Loading

Connected to #460
Connected to #813

As noticed by @Morendil here, inputs declared for several months are not properly taken into account.
@Morendil Morendil mentioned this issue Mar 14, 2019
Merged
@Morendil
Copy link
Contributor

What difference do you see between this and #842 ?

@fpagnoux
Copy link
Member Author

fpagnoux commented Mar 20, 2019 •
edited
Loading

This is a bug fix: some users inputs are silently ignored for no good reason. This can be fixed without taking any design decision or consensus, just by properly enforcing the currently documented behavior.

Implementing #842 would fix this issue too, but is also a deeper change of behavior, and probably needs some discussion. If this discussion takes a long time, I'd rather not have it on the critical path of fixing this serious bug, hence the 2 separate issues 🙂

@fpagnoux fpagnoux mentioned this issue Mar 28, 2019
Merged
@fpagnoux fpagnoux self-assigned this Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpagnoux fpagnoux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Br3nda @Morendil @fpagnoux