Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Price Validation Assistant): load less prices, but more often #1227

Merged
merged 1 commit into from
Jan 3, 2025
Merged

refactor(Price Validation Assistant): load less prices, but more often #1227

merged 1 commit into from
Jan 3, 2025

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Jan 3, 2025

What

2 small changes in the Price Validation Assistant inner working:

  • load less prices (to speed up display)
  • fix a bug where a user would validate prices, they would be removed, and the infinite scroll would not be triggered. preload prices instead in the background.

@raphodn raphodn merged commit 620a875 into master Jan 3, 2025
7 of 8 checks passed
@raphodn raphodn deleted the raphodn/price-validation-assistant-preload branch January 3, 2025 23:05
@raphodn raphodn linked an issue Jan 3, 2025 that may be closed by this pull request
New price validation assistant page (extracted and predicted from owned proofs) #1137
Open
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 3, 2025
Merged
@raphodn raphodn mentioned this pull request Jan 4, 2025
Open
raphodn added a commit that referenced this pull request Jan 20, 2025
@raphodn
refactor(Price Validation Assistant): reduce even more the number of …
25e5d41 
…price tags loaded. ref #1227
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New price validation assistant page (extracted and predicted from owned proofs)
1 participant
@raphodn