-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the product quantity unit (g or mL) #115
Comments
@raphael0202 @teolemon any ideas ? maybe if we sync the products' categories ? |
In my opinion, we should fetch |
Isn't this parsing already done in OFF server ? Might be complex to manage all the use cases (kg, g, ml, L, pounds...). Vs using the current clean and normalised field + a way to differenciate. But if there is no way to differenciate in the other fields then... |
It's done but there is no field to indicate the unit. We can also add a new field in Product Opener (but the codebase is in Perl) |
I'd go with a new field at the source ! |
Luckily a new field was recently added in Product Opener ! openfoodfacts/openfoodfacts-server#9377 |
@raphael0202 actually the new fields were in last month's release : https://github.com/openfoodfacts/openfoodfacts-server/releases/tag/v2.26.0 but i don't see them appearing in the v2 API ? is there some additional code to do ? |
It's available on newly updated product (ex: https://world.openfoodfacts.org/api/v2/product/0044118115928.json). |
Story
For each new product we fetch from Open Food Facts its
product_quantity
, a normalized number in g or mL.We need to find a way to know if the product is a beverage (mL), or solid (g), so that we can display the information accordingly in the frontend (price per kg or price per L).
Linked to #77
The text was updated successfully, but these errors were encountered: