Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate before deployment #52

Merged
merged 1 commit into from
Nov 23, 2023
Merged

chore: migrate before deployment #52

merged 1 commit into from
Nov 23, 2023

Conversation

raphael0202
Copy link
Contributor

Everything to know is in the title ;)

raphodn
raphodn approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@raphodn raphodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

@scesardev
Copy link

I do not have access to push a new branch but could you also add EXPOSE 8000 in the Dockerfile above the CMD ["uvicorn", "app.api:app",... line please ?

@raphael0202 raphael0202 merged commit bb91bfc into main Nov 23, 2023
5 checks passed
@raphael0202 raphael0202 deleted the migrate-on-deploy branch November 23, 2023 08:42
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphodn raphodn raphodn approved these changes

Assignees

@raphodn raphodn

@raphael0202 raphael0202

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphael0202 @scesardev @raphodn