fix: process one image at a time with Gemini #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
force-pushed
the
process-gemini-single-image
branch
from
2042727 to
a74e9e8
Compare
raphael0202
force-pushed
the
process-gemini-single-image
branch
from
a74e9e8 to
697cc8a
Compare
raphodn
approved these changes
Dec 22, 2024
| res = extract_from_price_tags(sample_files) | ||
| return Response(res, status=status.HTTP_200_OK) | ||
| labels = [extract_from_price_tag(sample_file) for sample_file in sample_files] | ||
| return Response({"labels": labels}, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
the response changes ? so that we change the frontend integration
There was a problem hiding this comment.
The response is exactly the same, no? The Labels TypedDict doesn't exist anymore
raphodn
reviewed
Dec 22, 2024
| ) | ||
| return json.loads(response.text) | ||
|
|
||
|
|
||
| def extract_from_price_tags(images: Image.Image) -> Labels: |
There was a problem hiding this comment.
I re-added the previous function + added a warning: d813e0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemini sometimes skips some images when prediction price tag labels, leading to mismatch between price tag and predictions.
We process here one price tag at a time, preventing this from happening.