Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Proof.type field #68

Merged
merged 3 commits into from
Nov 27, 2023
Merged

feat: add Proof.type field #68

merged 3 commits into from
Nov 27, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Nov 25, 2023

What

New field Proof.type to be able to differentiate proofs.
This field is validated by an enum that defines a list of possible values : PRICE_TAG, RECEIPT, GDPR_REQUEST, RETAILER

@raphodn raphodn self-assigned this Nov 25, 2023
@raphodn raphodn requested a review from raphael0202 November 25, 2023 16:30
app/enums.py Outdated
PRICE_TAG = "PRICE_TAG"
RECEIPT = "RECEIPT"
GDPR_REQUEST = "GDPR_REQUEST"
RETAILER = "RETAILER"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of proof retailers would submit? Isn't it enough that the data comes from a "verified" account (i.e account with an email address from the retailer)?

Copy link
Member Author

@raphodn raphodn Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I was including the COOPs in the RETAILER type

  • it could be just a screenshot of their CMS with a date ?
  • if we decide to add a price filter on "has proof" or not, it would be better to ask retailers to send a proof, no ?
  • or indeed like you say, we have a list of "verified" accounts, and we consider it a proxy to a proof

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Open Food Facts pro platform, we assume the data coming from trusted source to be accurate, as they're the source of the data it makes sense not to ask for an additional proof in my opinion.

if we decide to add a price filter on "has proof" or not, it would be better to ask retailers to send a proof, no ?

I was considering to add a flag "is_retailer" to the user table, so that we know which prices come from a verified source.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i removed it !

@raphodn raphodn merged commit d211c0a into main Nov 27, 2023
3 checks passed
@raphodn raphodn deleted the raphodn/proof-type branch November 27, 2023 09:10
@teolemon teolemon added the Proofs label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants