-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Proof.type field #68
Conversation
app/enums.py
Outdated
PRICE_TAG = "PRICE_TAG" | ||
RECEIPT = "RECEIPT" | ||
GDPR_REQUEST = "GDPR_REQUEST" | ||
RETAILER = "RETAILER" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of proof retailers would submit? Isn't it enough that the data comes from a "verified" account (i.e account with an email address from the retailer)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi I was including the COOPs in the RETAILER type
- it could be just a screenshot of their CMS with a date ?
- if we decide to add a price filter on "has proof" or not, it would be better to ask retailers to send a proof, no ?
- or indeed like you say, we have a list of "verified" accounts, and we consider it a proxy to a proof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Open Food Facts pro platform, we assume the data coming from trusted source to be accurate, as they're the source of the data it makes sense not to ask for an additional proof in my opinion.
if we decide to add a price filter on "has proof" or not, it would be better to ask retailers to send a proof, no ?
I was considering to add a flag "is_retailer" to the user table, so that we know which prices come from a verified source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i removed it !
49cb44e
to
4aa5ddb
Compare
What
New field
Proof.type
to be able to differentiate proofs.This field is validated by an enum that defines a list of possible values :
PRICE_TAG
,RECEIPT
,GDPR_REQUEST
,RETAILER