-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display new Nutri-Score (except on fr.openfoodfacts.org) #10163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📖 Knowledge Panels
https://wiki.openfoodfacts.org/Knowledge_panels
Template::Toolkit
The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Display
Attributes
https://wiki.openfoodfacts.org/Product_Attributes
🚦 Nutri-Score
labels
Apr 22, 2024
github-actions
bot
added
API
Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…)
🧪 integration tests
labels
May 3, 2024
alexgarel
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: see my comment.
Co-authored-by: Alex Garel <alex@openfoodfacts.org>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…)
Attributes
https://wiki.openfoodfacts.org/Product_Attributes
Display
🧪 integration tests
📖 Knowledge Panels
https://wiki.openfoodfacts.org/Knowledge_panels
Nutri-Score v2
🚦 Nutri-Score
Template::Toolkit
The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
🧪 tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Nutri-Score attribute so that it uses the 2023 Nutri-Score, and is linked to the new Nutri-Score 2023 knowledge panel, for all users, and for all countries (including world), except fr.openfoodfacts.org
The new Nutri-Score logo with "New calculation" is shown on the attribute, but it is not very legible. Maybe we could keep it only on the knowledge panel on the product page.