-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pull MongoDB and Redis from shared-services repo #10266
Conversation
This is mostly done, although I noticed the devcontainer.json is still mentioning redis and mongodb so assume this might need some changes to cater for shared-services. @alexgarel, @stephanegigandet , @teolemon I'm not very familiar with how devcontainers work - who is the resident expert? |
I have made edits to the devcontainer.json and I think it works now. I basically added an initializeCommand to start the dependencies first (make run_deps). @hangy , I notice you've appeared in a lot of devcontainers conversations so perhaps you could check I've got this right? |
I think this is @hangy. I personally don't use it yet but would be glad to have an introduction also :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @john-gom, looks good to me. I have one or two remarks.
I think you can remove docker/test.yml
networks: | ||
# This network allows access to shared services like MongoDB and Redis | ||
shared_network: | ||
name: shared_network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shan't we add a project name or something like that ?
Otherwise you can't work on two clones of the repo at the same time.
I think the COMPOSE_PROJECT_NAME is shared with dependencies, right ?
In this case, prefix it:
name: shared_network | |
name: ${COMPOSE_PROJECT_NAME}_shared_network |
Note: do it only if it's simple enough.
I haven't used devcontainers with OFF in a while, but the changes look fine to me. They devcontainers config is also used for GitPod/GitHub Codespaces, IRC. |
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
a60528d
to
c6f0bde
Compare
Quality Gate passedIssues Measures |
3 similar comments
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
What
Create a test.yml for integration tests but otherwise MongoDB and Redis come from the shared-services repo.
https://github.com/openfoodfacts/openfoodfacts-shared-services