Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pull MongoDB and Redis from shared-services repo #10266

Merged
merged 14 commits into from
Jun 21, 2024
Merged

Conversation

john-gom
Copy link
Contributor

@john-gom john-gom commented May 10, 2024

@github-actions github-actions bot added MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products 🐋 Docker https://docker-curriculum.com/ labels May 10, 2024
@teolemon teolemon requested a review from alexgarel May 13, 2024 15:12
docker/test.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jun 7, 2024
@john-gom
Copy link
Contributor Author

john-gom commented Jun 7, 2024

This is mostly done, although I noticed the devcontainer.json is still mentioning redis and mongodb so assume this might need some changes to cater for shared-services. @alexgarel, @stephanegigandet , @teolemon I'm not very familiar with how devcontainers work - who is the resident expert?

@john-gom john-gom marked this pull request as ready for review June 7, 2024 09:05
@john-gom john-gom requested a review from a team as a code owner June 7, 2024 09:05
@john-gom
Copy link
Contributor Author

john-gom commented Jun 7, 2024

This is mostly done, although I noticed the devcontainer.json is still mentioning redis and mongodb so assume this might need some changes to cater for shared-services. @alexgarel, @stephanegigandet , @teolemon I'm not very familiar with how devcontainers work - who is the resident expert?

I have made edits to the devcontainer.json and I think it works now. I basically added an initializeCommand to start the dependencies first (make run_deps). @hangy , I notice you've appeared in a lot of devcontainers conversations so perhaps you could check I've got this right?

@alexgarel
Copy link
Member

This is mostly done, although I noticed the devcontainer.json is still mentioning redis and mongodb so assume this might need some changes to cater for shared-services. @alexgarel, @stephanegigandet , @teolemon I'm not very familiar with how devcontainers work - who is the resident expert?

I think this is @hangy. I personally don't use it yet but would be glad to have an introduction also :-D

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @john-gom, looks good to me. I have one or two remarks.

I think you can remove docker/test.yml

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
networks:
# This network allows access to shared services like MongoDB and Redis
shared_network:
name: shared_network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shan't we add a project name or something like that ?

Otherwise you can't work on two clones of the repo at the same time.

I think the COMPOSE_PROJECT_NAME is shared with dependencies, right ?

In this case, prefix it:

Suggested change
name: shared_network
name: ${COMPOSE_PROJECT_NAME}_shared_network

Note: do it only if it's simple enough.

docker/test.yml Outdated Show resolved Hide resolved
@hangy
Copy link
Member

hangy commented Jun 11, 2024

This is mostly done, although I noticed the devcontainer.json is still mentioning redis and mongodb so assume this might need some changes to cater for shared-services. @alexgarel, @stephanegigandet , @teolemon I'm not very familiar with how devcontainers work - who is the resident expert?

I think this is @hangy. I personally don't use it yet but would be glad to have an introduction also :-D

I haven't used devcontainers with OFF in a while, but the changes look fine to me. They devcontainers config is also used for GitPod/GitHub Codespaces, IRC.

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 12, 2024
john-gom added 13 commits June 20, 2024 17:25
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Signed-off-by: John Gomersall <thegoms@gmail.com>
Copy link

3 similar comments
Copy link

Copy link

Copy link

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 21, 2024
@john-gom john-gom merged commit e706114 into main Jun 21, 2024
12 checks passed
@john-gom john-gom deleted the shared-services branch June 21, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐋 Docker https://docker-curriculum.com/ GitHub Actions Pull requests that update Github_actions code MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products Shared services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Product Opener to fetch Redis and MongoDB Dependencies from openfoodfacts-shared-services repo
4 participants