fix: Banner accessibility #10299
Merged
fix: Banner accessibility #10299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CSS
Template::Toolkit
| <div class="donation-banner__close"> | ||
| <span id="hide-donate-banner" class="material-icons" onclick="DonationButton();">close</span> | ||
| <button id="hide-donate-banner" class="material-icons modest" onclick="DonationButton();" onkeypress="DonationButton();">close</button> |
There was a problem hiding this comment.
What's the "modest" class?
There was a problem hiding this comment.
It's a sveetoy class to make the button smaller
|
Thanks for the PR! If there are any visual differences, could you add before / after screenshots? |
|
Before: After : there is a small difference at the button, is this problematic? |
Thanks, looks fine to me. The language is different though ;) |
CharlesNepote
approved these changes
May 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Accessibility for donate banner
Give role to spans
Alt to images
Make the close button accessible
Related issue(s) and discussion