Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add alts to donation-banner__image #10300

Conversation

bazylevnik0
Copy link
Contributor

@bazylevnik0 bazylevnik0 commented May 16, 2024

What

Add alts to images.

Related issue(s) and discussion

@bazylevnik0 bazylevnik0 requested a review from a team as a code owner May 16, 2024 13:54
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🎁 donations labels May 16, 2024
@bazylevnik0 bazylevnik0 marked this pull request as draft May 16, 2024 14:01
@bazylevnik0 bazylevnik0 marked this pull request as ready for review May 16, 2024 14:37
@bazylevnik0
Copy link
Contributor Author

I also found here:

https://stackoverflow.com/questions/38380115/is-there-an-equivalent-to-the-alt-attribute-for-div-elements

Proposal to use not alt but aria-label for divs...

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@stephanegigandet
Copy link
Contributor

@Valimp also has a related PR: #10299

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.98%. Comparing base (dc04d18) to head (d0a410e).
Report is 347 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10300      +/-   ##
==========================================
+ Coverage   49.54%   49.98%   +0.44%     
==========================================
  Files          67       74       +7     
  Lines       20650    21135     +485     
  Branches     4980     5057      +77     
==========================================
+ Hits        10231    10565     +334     
- Misses       9131     9281     +150     
- Partials     1288     1289       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet stephanegigandet merged commit 5bb2ccc into openfoodfacts:main May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 donations Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] Banner - Image elements don't have a alt attribute
3 participants