Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance revert feature #10486

Open
Tracked by #10271
CharlesNepote opened this issue Jun 24, 2024 · 1 comment
Open
Tracked by #10271

Enhance revert feature #10486

CharlesNepote opened this issue Jun 24, 2024 · 1 comment
Labels
🧽 Data quality - Remediation 🧽 Data quality https://wiki.openfoodfacts.org/Quality

Comments

@CharlesNepote
Copy link
Member

Revert feature is great, but lacking important things:

  • current revert also delete new pictures
  • current revert is reverting all the modifications
  • revert does not send feedback to the user whose contributions have been reverted

Revert evolution

Here is how it could work:

  • the user requests a product's page (for reading or editing)
  • the system displays the page, listing each past modification in summary and offering the possibility of returning to a previous version [already done]
  • the user selects a previous version and asks for it to be restored [already done]
  • the system displays the details of modifications made to the previous version [new]
    • [alternative] the system displays the details of the changes made to the previous version, with the option of selecting which changes to revert
    • [option] the system also offer the possibility to write something to the user whose modifications are concerned by the revert (with moderators in copy)
  • user validates changes to previous version
  • the system saves the changes, keeping the images [new], indicating that this is a restore based on version XX
    • [option] if the "reverter" has asked for it, the system sends the email to the user whose modifications are concerned by the revert (from no-reply@openfoodfacts.org?), with moderators in copy

Revert monitoring

Revert should be easily auditable: what? how many? who?
A facet and an API route could be interesting to monitor reverts. Everyone should be able to use it. The messages should stay private but should be able to be seen by moderators.

Implementation

I have no idea on how to do this and how costly it can be. Maybe be we can do this step by step.

See also

@October-Food-Facts
Copy link

I had once commented about improving the function of reverting to older revisions while keeping new pictures. In my idea, thought to be as little work as possible, it needs only an additional new prompt after the one currently implemented:

  • Click "Revert to this revision" > generates alert box asking "Are you sure you want to revert to this older revision and discard any new pictures uploaded?" OK / Cancel, which moves on to a new second prompt asking "Do you instead want to revert to this older revision while keeping any new pictures?" OK / Cancel"

Currently, there is only one prompt.

Current Prompt

Relevant: user moon-rabbit said on Slack that they didn't know that reverting deleted pictures, until they realized the mistake caused. These suggested prompts use detailed wording useful to moderators.

@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality - Remediation 🧽 Data quality https://wiki.openfoodfacts.org/Quality
Projects
Status: To discuss and validate
Status: To do
Development

No branches or pull requests

3 participants