Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make facets URLS /nova-group/unknown and /nova_group/not-applicable work #10493

Closed
stephanegigandet opened this issue Jun 25, 2024 · 0 comments · Fixed by #10498
Closed

Make facets URLS /nova-group/unknown and /nova_group/not-applicable work #10493

stephanegigandet opened this issue Jun 25, 2024 · 0 comments · Fixed by #10498
Labels
✨ Feature Features or enhancements to Open Food Facts server Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova

Comments

@stephanegigandet
Copy link
Contributor

From @raphael0202 : "A strange bug that a contributor asked me about by mail:
on the NOVA group of the UK country: https://uk.openfoodfacts.org/nova-groups
there are 2 "Unknown" (one corresponding to "unknown" NOVA, one to "not-applicable" NOVA.
the counts are not the same depending between the tag list page and when we click on the tag (85k vs 1209) for "unknown" and 318 vs 0 for "not-applicable""

For the different "unknown" count, it's because by default, for tags fields, when we search for "unknown", we look for products with no value (e.g. for /category/unknown). But a few tags, like NOVA, have an "unknown" value, we need to disable this behavior for them.
(in function sub add_params_to_query ($request_ref, $query_ref) { )

We probably need to do the same for a few other fields like food_groups, Eco-Score and Nutri-Score.

@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Jun 25, 2024
@teolemon teolemon added the Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova label Jun 25, 2024
@teolemon teolemon added the ✨ Feature Features or enhancements to Open Food Facts server label Jun 25, 2024
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Features or enhancements to Open Food Facts server Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants