Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various fixes to data sync with CRM #10494

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

4nt0ineB
Copy link
Member

What

Fixed:

  • A contact was not created in the CRM when the org was validated and the main contact was not the creator.
  • The last logged member of the org was not actually stored in the org .sto (missing store_org call)
  • The last import type was not stored in the org but only updated on the crm

@4nt0ineB 4nt0ineB requested a review from a team as a code owner June 25, 2024 12:34
@github-actions github-actions bot added Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🏭 Producers Platform - Odoo OdooCRM is used by the Open Food Facts team to manage producers (and more) relationships Minion file import multilingual products 🏭 Orgs labels Jun 25, 2024
@4nt0ineB 4nt0ineB changed the title fix: various fixes of sync data with the CRM fix: various fixes to data sync with CRM Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49.34%. Comparing base (dc04d18) to head (650a99f).
Report is 440 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/Orgs.pm 0.00% 11 Missing ⚠️
lib/ProductOpener/Import.pm 33.33% 1 Missing and 1 partial ⚠️
lib/ProductOpener/CRM.pm 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10494      +/-   ##
==========================================
- Coverage   49.54%   49.34%   -0.21%     
==========================================
  Files          67       76       +9     
  Lines       20650    21700    +1050     
  Branches     4980     5207     +227     
==========================================
+ Hits        10231    10707     +476     
- Misses       9131     9679     +548     
- Partials     1288     1314      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@4nt0ineB 4nt0ineB merged commit 2105897 into openfoodfacts:main Jun 25, 2024
11 checks passed
@4nt0ineB 4nt0ineB deleted the crm-fixes branch July 12, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data import file import Minion multilingual products 🏭 Orgs 🏭 Producers Platform - Odoo OdooCRM is used by the Open Food Facts team to manage producers (and more) relationships 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers 🧪 tests
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants