feat: display new fields in orgs table #10499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Template::Toolkit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10499 +/- ##
==========================================
- Coverage 49.54% 49.33% -0.21%
==========================================
Files 67 76 +9
Lines 20650 21702 +1052
Branches 4980 5208 +228
==========================================
+ Hits 10231 10707 +476
- Misses 9131 9681 +550
- Partials 1288 1314 +26 ☔ View full report in Codecov by Sentry. |
4nt0ineB
reviewed
Jun 27, 2024
| <td>[% display_date_tag(org.created_t) %]</td> | ||
| <td>[% display_date_tag(org.last_logged_member_t) %]</td> | ||
| <td>[% org.last_import_type %]</td> |
There was a problem hiding this comment.
It seems that you are displaying the wrong value here.
In you screenshot wee can see "Manual import" in the "Last import date" column.
There was a problem hiding this comment.
Right, the last import data is missing.
4nt0ineB
reviewed
Jun 27, 2024
| <td>[% display_date_tag(org.created_t) %]</td> | ||
| <td>[% display_date_tag(org.last_logged_member_t) %]</td> | ||
| <td>[% org.last_import_type %]</td> | ||
| <td>[% org.creator %]</td> |
There was a problem hiding this comment.
It seems that you are displaying the creator instead of the data source of the last import.
stephanegigandet
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot