Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lint spaces in taxonomies #10563

Merged
merged 8 commits into from
Jul 22, 2024
Merged

feat: Lint spaces in taxonomies #10563

merged 8 commits into from
Jul 22, 2024

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Jul 18, 2024

As we use Taxonomy editor, it's better to be consistent with styling.

This adds some space normalization to taxonomies linter.

Note: to review this PR:

  • do a review without space changes
    image
  • go on the lint-spaces branch and check files there

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 additives 🥜 Allergens categories 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧽 Data quality https://wiki.openfoodfacts.org/Quality 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 📦 Packaging shapes https://github.com/openfoodfacts/openfoodfacts-server/blob/main/taxonomies/packaging_shapes.txt Ingredients processing 🥗 Ingredients 🏭 Producer platform - improvement opportunities labels Jul 18, 2024
@github-actions github-actions bot added status system Products have a number of completion states, eg: https://world.openfoodfacts.org/states Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova Food groups labels Jul 19, 2024
@alexgarel alexgarel requested a review from a team as a code owner July 19, 2024 12:20
@github-actions github-actions bot added the Tags label Jul 19, 2024
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jul 21, 2024
Copy link

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jul 22, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you

@alexgarel alexgarel merged commit c01cf91 into main Jul 22, 2024
11 checks passed
@alexgarel alexgarel deleted the lint-spaces branch July 22, 2024 12:07
stephanegigandet pushed a commit that referenced this pull request Jul 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.38.0](v2.37.0...v2.38.0)
(2024-07-23)


### Features

* add new product event types for redis queue
([#10530](#10530))
([339dbc4](339dbc4))
* add product data to org table
([#10534](#10534))
([dce0518](dce0518))
* added a drag and drop zone in pro platform
([#10569](#10569))
([ce60b8f](ce60b8f))
* allow orgs to not have a main contact if imported from an aggregator
([#10531](#10531))
([ead1b0c](ead1b0c))
* launch the exports for all organizations that have the checkbox…
([#10561](#10561))
([c3aa2d1](c3aa2d1))
* Lint spaces in taxonomies
([#10563](#10563))
([c01cf91](c01cf91))
* make valid org filter field a dropdown
([#10524](#10524))
([b38e62c](b38e62c))
* measure and log duration of request and mongodb / off-query que…
([#10557](#10557))
([2cb1b1e](2cb1b1e))
* packaging add Ireland
([#10533](#10533))
([3f3196e](3f3196e)),
closes
[#1572](#1572)


### Bug Fixes

* add product_type to redis events
([#10550](#10550))
([6bd1c0e](6bd1c0e))
* added barcode-svg
([#10242](#10242))
([8da89da](8da89da))
* broken user space on pro platform
([#10541](#10541))
([b6e3017](b6e3017))
* change_main_contact.pl
([#10548](#10548))
([b2f90ea](b2f90ea))
* disable caching on pro platform
([#10516](#10516))
([4ccd714](4ccd714))
* GDSN import from Alnatura
([#10556](#10556))
([6e2673a](6e2673a))
* improve generated data for a .pl script
([#10532](#10532))
([1cab04c](1cab04c))
* pro_moderator_owner not stored for the admin/moderator user through
org/[orgid] facet
([#10560](#10560))
([e0441c6](e0441c6))
* rate limiter log config
([#10535](#10535))
([9a5168d](9a5168d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🥜 Allergens categories 🧽 Data quality https://wiki.openfoodfacts.org/Quality Food groups Ingredients processing 🥗 Ingredients Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. 📦 Packaging shapes https://github.com/openfoodfacts/openfoodfacts-server/blob/main/taxonomies/packaging_shapes.txt 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🏭 Producer platform - improvement opportunities status system Products have a number of completion states, eg: https://world.openfoodfacts.org/states Tags 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
Archived in project
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants