Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevention - Nutrition - Reject edits where all entered nutrition values are 0 #1564

Closed
Tracked by #10272
, #5523
...
stephanegigandet opened this issue Dec 7, 2018 · 5 comments · Fixed by #9320
Closed
Tracked by #10272
, #5523
...

Prevention - Nutrition - Reject edits where all entered nutrition values are 0 #1564

stephanegigandet opened this issue Dec 7, 2018 · 5 comments · Fixed by #9320
Assignees
@benbenben2
Labels
API WRITE WRITE API to allow sending product info and image 🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them 🧽 Data quality - Nutrition 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality Nutrition facts 🎯 P1 candidate

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Dec 7, 2018 •
edited by teolemon
Loading

What

  • Some users from 3rd party apps just enter 0s everywhere.
  • Reject edits where all entered nutrition values are 0

Code pointers

Part of
@teolemon
Copy link
Member

teolemon commented Dec 7, 2018

Perhaps a quality facet first ?

@teolemon teolemon added Nutrition facts 🧽 Data quality https://wiki.openfoodfacts.org/Quality API WRITE WRITE API to allow sending product info and image labels Dec 7, 2018
@teolemon teolemon added 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them labels Jul 13, 2019
@teolemon
Copy link
Member

https://github.com/openfoodfacts/openfoodfacts-server/pull/800/files to get a sense of where EditRules live in the code

This was referenced Aug 21, 2021
Open
Open
@teolemon teolemon added 🎯 P1 candidate 🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them 🧽 Data quality - Nutrition and removed 🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them labels Sep 12, 2021
@teolemon teolemon changed the title Reject edits where all entered nutrition values are 0 Prevention - Reject edits where all entered nutrition values are 0 Oct 11, 2021
@teolemon teolemon changed the title Prevention - Reject edits where all entered nutrition values are 0 Prevention - Nutrition - Reject edits where all entered nutrition values are 0 Oct 11, 2021
@benbenben2 benbenben2 mentioned this issue May 12, 2023
Open
2 tasks
@benbenben2
Copy link
Collaborator

@stephanegigandet
18984 products in this case.
What do you want to do exactly there? Reject edits? Or facet?

@stephanegigandet
Copy link
Contributor Author

Maybe a facet first indeed, it's likely that there could be false positives (products that do have 0 everywhere).

@benbenben2 benbenben2 mentioned this issue Nov 14, 2023
Merged
@benbenben2
Copy link
Collaborator

773 products have ALL nutrition values equal to 0: mirabelle

@benbenben2 benbenben2 self-assigned this Nov 14, 2023
@benbenben2 benbenben2 moved this from To do to Needs review in 🧽 Ensuring Data Quality Nov 14, 2023
@github-project-automation github-project-automation bot moved this from Needs review to Done in 🧽 Ensuring Data Quality Dec 5, 2023
@teolemon teolemon mentioned this issue May 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbenben2 benbenben2

Labels
API WRITE WRITE API to allow sending product info and image 🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them 🧽 Data quality - Nutrition 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality Nutrition facts 🎯 P1 candidate
Projects
🍊 Open Food Facts Server issues
Archived in project
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: dq_all_val_in_nutrition_are_identical openfoodfacts/openfoodfacts-server
3 participants
@teolemon @stephanegigandet @benbenben2