Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse ingredients "with" (A with B, A processed with B etc.) #3065

Open
Tracked by #9096
stephanegigandet opened this issue Mar 19, 2020 · 6 comments
Open
Tracked by #9096

Parse ingredients "with" (A with B, A processed with B etc.) #3065

stephanegigandet opened this issue Mar 19, 2020 · 6 comments
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🎯 P1 candidate ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Mar 19, 2020

What

  • A lot of ingredients contains "with": https://world.openfoodfacts.org/ingredients?filter=-with-
  • We should try to parse them to mark them as sub-ingredients. We need to also note that they are not all the sub-ingredients. If we have "A with B", then we can change it to "A (B)", but the percent computation should not assume that the %B is equal to the % of A.
  • We also need to review special cases. (e.g. "chicken breast with skin" etc.)

Part of

image

https://fr.openfoodfacts.org/ingredients?filter=-avec-

image

@stephanegigandet stephanegigandet added ✨ Feature Features or enhancements to Open Food Facts server 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Mar 19, 2020
@muskangarg21
Copy link
Contributor

@stephanegigandet may I work on this ?

@stephanegigandet
Copy link
Contributor Author

Hi @muskangarg21: the corresponding code is very complex and when it changes, it affects many other things, so that's probably not a good issue to get familar with the code base.

If you want to take a look, it's the parse_ingredients_text() function in Ingredients.pm

@teolemon
Copy link
Member

@stephanegigandet
Copy link
Contributor Author

@teolemon : most of the "without" are related to labels, there's another parsing feature for that. ("ingredient + some_label")

@github-actions
Copy link
Contributor

Stale issue message

Copy link
Contributor

github-actions bot commented Mar 5, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 5, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🎯 P1 candidate ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To do
Status: To discuss and validate
Development

No branches or pull requests

3 participants