Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor queries with codes like zh_CN or pt_BR #4091

Open
Tracked by #5523
teolemon opened this issue Aug 30, 2020 · 4 comments
Open
Tracked by #5523

Honor queries with codes like zh_CN or pt_BR #4091

teolemon opened this issue Aug 30, 2020 · 4 comments
Labels
API READ All READ APIs include Product, Search… API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🎯 P1 ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@teolemon
Copy link
Member

teolemon commented Aug 30, 2020

What

Part of

@teolemon teolemon added the ✨ Feature Features or enhancements to Open Food Facts server label Aug 30, 2020
@teolemon
Copy link
Member Author

We already do it in write mode:

# some apps may send pt-BR

@teolemon teolemon added the API READ All READ APIs include Product, Search… label Aug 30, 2020
@teolemon teolemon added the 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps label Aug 30, 2020
@hangy
Copy link
Member

hangy commented Aug 30, 2020

IMHO, the app shouldn't be sending these requests right now. The pt_BR to pt change was implemented as a workaround for some misbehaving external client, but we currently don't support more complex ISO codes officially (also see #667). Simply removing stuff could be really hurtful in cases like zh-hans vs zh-hant vs zh-tw.

@stephanegigandet
Copy link
Contributor

I agree with @hangy, we don't want apps to send us extended language codes, the more workaround we had, the more bugs we will have down the road. Here the right thing to do is to change the OFF app so that it sends only the 2 letter code.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 14, 2021
@teolemon teolemon removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 19, 2021
@teolemon teolemon added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Aug 21, 2021
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 15, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API READ All READ APIs include Product, Search… API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🎯 P1 ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Status: 💬 To discuss and validate
Development

No branches or pull requests

3 participants