Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eco-Score calculation details dropdown is not fully visible on some screens #4789

Closed
Tracked by #5513 ...
teolemon opened this issue Jan 26, 2021 · 9 comments
Closed
Tracked by #5513 ...
Labels
🐛 bug This is a bug, not a feature request. CSS 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products JavaScript Product Page ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@teolemon
Copy link
Member

The Eco-Score methodology is not fully visible on some screen.
In some case, the popup explaining the points is masked.

@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products labels Jan 26, 2021
@stephanegigandet
Copy link
Contributor

which screen? please include a product url

@teolemon
Copy link
Member Author

I was on a videoconference, it was a windows laptop. It's that bug that we usually solve by hitting tab a few times.

@teolemon
Copy link
Member Author

teolemon commented Jan 26, 2021

It should probably happen on all products, given a small enough product page: https://fr.openfoodfacts.org/marque/food4good

@stephanegigandet stephanegigandet changed the title The Eco-Score methodology is not fully visible on some screen Eco-Score calculation details dropdown is not fully visible on some screen Jan 26, 2021
@stephanegigandet
Copy link
Contributor

I cannot reproduce it, when the dropdown is opened, the page is extended.

Can you reproduce it?

	# call equalizer when dropdown content is shown
	$initjs .= <<JS
\$('.f-dropdown').on('opened.fndtn.dropdown', function() {
   \$(document).foundation('equalizer', 'reflow');
});
JS
;

@stephanegigandet
Copy link
Contributor

It can happen if the page is resized after opening the dropdown.

@teolemon
Copy link
Member Author

I saw it happen live. No resize, probably a low screen resolution.

@teolemon
Copy link
Member Author

no, does not happen consistently

@teolemon teolemon changed the title Eco-Score calculation details dropdown is not fully visible on some screen Eco-Score calculation details dropdown is not fully visible on some screens Jan 26, 2021
@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Apr 27, 2021
@stephanegigandet
Copy link
Contributor

#6447 is a duplicate (but with a screenshot), so I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. CSS 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products JavaScript Product Page ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Development

No branches or pull requests

2 participants