Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to edited product #5963

Merged
merged 2 commits into from
Oct 12, 2021
Merged

fix: link to edited product #5963

merged 2 commits into from
Oct 12, 2021

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Oct 11, 2021

The issue was that the template used "product_url" as a template variable, but we recently made available the product_url() function to all templates, so the function was called instead of the variable.

fixes #5954

@stephanegigandet stephanegigandet requested a review from a team as a code owner October 11, 2021 15:49
@stephanegigandet stephanegigandet added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Oct 11, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit 942fd34 into main Oct 12, 2021
@stephanegigandet stephanegigandet deleted the edited_product_link branch October 12, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to product page broken in "Changes saved." page
2 participants