Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an edit rule for halal-app-chakib #6043

Closed
teolemon opened this issue Oct 30, 2021 · 5 comments · Fixed by #8077
Closed

Create an edit rule for halal-app-chakib #6043

teolemon opened this issue Oct 30, 2021 · 5 comments · Fixed by #8077
Labels
3rd party contributions Contributions from 3rd party apps through the Product WRITE API Data destroying issue This issue relates to an on-going issue actively destroying product data ! 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🎯 P1

Comments

@teolemon
Copy link
Member

teolemon commented Oct 30, 2021 •
edited
Loading

Create an edit rule for halal-app-chakib since the app stores French translation of the categories in English, thus destroying Eco-Scores and Nutri-Scores
https://world.openfoodfacts.org/product/4056489012481/nectar-de-goyave-solevita#

October 30, 2021 at 6:41:21 PM CEST - halal-app-chakib Data (Changed: categories) -- Nutriments (Changed: nutrition-score-fr) - (app)added with the allergy Android app - view

Code pointers

Edit rules

Part of
@teolemon teolemon added ✅ Task 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits labels Oct 30, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 29, 2022
@teolemon teolemon removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. ✅ Task labels Jan 29, 2022
@teolemon teolemon added the 3rd party contributions Contributions from 3rd party apps through the Product WRITE API label Apr 1, 2022
@teolemon teolemon added 🎯 P1 Data destroying issue This issue relates to an on-going issue actively destroying product data ! labels Nov 21, 2022
@teolemon
Copy link
Member Author

Still an issue, on very popular products: https://world.openfoodfacts.org/product/5449000131836/coca-cola-zero

@aleene
Copy link
Contributor

aleene commented Nov 21, 2022

The app also creates a lot of empty products.

@alexgarel
Copy link
Member

Could we do this on robotoff side ? A bit like the idea of check spelling, if a category, label, etc. has just a language mismatch, fix it.

@teolemon teolemon mentioned this issue Dec 13, 2022
Open
4 tasks
@teolemon
Copy link
Member Author

Here's the place where edit rules live:
https://github.com/openfoodfacts/openfoodfacts-server/blob/main/lib/ProductOpener/Config_off.pm#L204

And yes, I'm commenting because of a broken product I spotted

@alexgarel alexgarel mentioned this issue Jan 27, 2023
Merged
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Feb 7, 2023
Merged
@October-Food-Facts October-Food-Facts mentioned this issue Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3rd party contributions Contributions from 3rd party apps through the Product WRITE API Data destroying issue This issue relates to an on-going issue actively destroying product data ! 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🎯 P1
Projects
Product Opener - Sprint
Status: No status
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 2.7.0 openfoodfacts/openfoodfacts-server
3 participants
@alexgarel @aleene @teolemon