Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quote some strings in knowledge panel JSON output #6076

Merged
merged 2 commits into from
Nov 16, 2021
Merged

fix: quote some strings in knowledge panel JSON output #6076

merged 2 commits into from
Nov 16, 2021

Conversation

stephanegigandet
Copy link
Contributor

small fix, as Agribalyse category names can contain quotes.

I'll later add better notifications with sentry for this issue.

@stephanegigandet stephanegigandet added the 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels label Nov 15, 2021
@stephanegigandet stephanegigandet requested a review from a team as a code owner November 15, 2021 13:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit d9ebe60 into main Nov 16, 2021
@stephanegigandet stephanegigandet deleted the panels branch November 16, 2021 08:20
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees
No one assigned
Labels
environment 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels
Projects
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @teolemon