Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change string to boolean for expanded knowledge panel #6081

Merged
merged 3 commits into from
Nov 16, 2021
Merged

fix: change string to boolean for expanded knowledge panel #6081

merged 3 commits into from
Nov 16, 2021

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Nov 16, 2021 •
edited
Loading

I'm not sure why github lists 2 commits that have already been merged from this panels branch to main.
The 3rd one is not in main yet.

@stephanegigandet stephanegigandet requested a review from a team as a code owner November 16, 2021 14:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit b05e668 into main Nov 16, 2021
@stephanegigandet stephanegigandet deleted the panels branch November 16, 2021 15:30
alexgarel
alexgarel reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (oups, I was late :-D)

@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel left review comments

@jasmeet0817 jasmeet0817 jasmeet0817 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
old prs
Status: No status
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @alexgarel @jasmeet0817