-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Categories taxonomy improvements for Wikidata and IGPs #6196
Conversation
Errors in the categories taxonomy definition:
|
Errors in the categories taxonomy definition:
|
a85428b
to
0911426
Compare
<en:Colas The 2988 empty wikidata entries make the PR a pain to review. If you really want to add them, I suggest to first remove them, file a PR, get it merged, and then add back the empty entries, so that we don't have them in the middle of the other changes. The same strategy could be used for things were one field is renamed in another. Otherwise it's very hard to see the manual changes (the ones that would be useful to review) from the rest. |
e2de053
to
5b70413
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Just one thing:
<en:Wines from Greece
el:Ritsona, Ριτσώνα
-country:en:Greece
+origins:en: en:Greece
--> we have a mechanism to check properties of parent entries, so you can just add origins:en: en:Greece once on the parent entry en:Wines from Greece, without having to add it to all children.
It's ironically the opposite as your comment in Slack. We'll have to use a case by case approach to see where we can safely do so
|
Thanks a lot for the review @stephanegigandet 🎉 |
Kudos for this PR @teolemon |
What
PS: I'm really sorry that the changes are too big for the web editor :-/
Part of