fix: ensure windows newlines don't break panels #6254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanegigandet
added
the
📖 Knowledge Panels
alexgarel
reviewed
Jan 7, 2022
| @@ -179,7 +179,8 @@ The function converts the multiline string into a single line string. | |||
|
|
|||
| sub convert_multiline_string_to_singleline($) { | |||
| my $line = shift; | |||
| $line =~ s/\n/\\n/sg; | |||
| # \R will match all Unicode newline sequence | |||
| $line =~ s/\R/\\n/sg; | |||
There was a problem hiding this comment.
wow this \R character set is cool :-)
There was a problem hiding this comment.
just discovered it ;) We probably could look for instances of \n and replace them.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some producers have imported ingredients lists with \r\n sequences, and that broke the JSON used by knowledge panels.
this fixes the generation of the panels.
we probably need another fix to normalize newlines when we edit products / import data.