feat: Extract ingredients origins from labels and use them in Eco-Score #6377
Conversation
github-actions
bot
added
🌱 Green-Score
lib/ProductOpener/Ingredients.pm
Outdated
| sub has_specific_ingredient_property($$$) { | ||
|
|
||
| my $product_ref = shift; | ||
| my $ingredient_id = shift; |
There was a problem hiding this comment.
I would rename as searched_id because it's very hard not to mess things up underneath between ingredient_id ingredient_ref and specific_ingredient_id.
There was a problem hiding this comment.
otherwise, underneath use specific rather than ingredient in name: specific_ref, specific_id
lib/ProductOpener/Ingredients.pm
Outdated
| and ((not defined $ingredient_id) or (is_a("ingredients", $ingredient_id, $specific_ingredient_id)))) { | ||
|
|
||
| $value = $ingredient_ref->{origins}; | ||
| last; |
There was a problem hiding this comment.
I'm asking myself in if this kind of treatment we should not continue for sanity checks. Something like:
defined $value and $value = $ingredient_ref->{origins}
or log->warning("Got more than one specific ingredient origin ", {product => $product_ref->{id}, ingredient_id => $ingredient_id});There was a problem hiding this comment.
good idea. I also just noticed that I hardcoded "origins" in this function even though it's passed a $property parameter.
| en:French pork | ||
| fr:Viande Porcine Française, VPF, viande de porc française, Le Porc Français, Porc Origine France, porc français, porc 100% France | ||
| origins:en: en:france | ||
| ingredients:en: en:pork |
There was a problem hiding this comment.
You should document that origins can be a list, but not ingredients (from what I understand).
stephanegigandet
added
🥗🔍 Ingredients analysis
Co-authored-by: Alex Garel <alex@garel.org>
Co-authored-by: Alex Garel <alex@garel.org>
github-actions
bot
added
🥗 Ingredients
labels
🧬 Taxonomies
|
Kudos, SonarCloud Quality Gate passed!
|
What
3 changes:
en:French eggs, Eggs from France
ingredients:en: en:egg
origins:en: en:france
This info is added to the "specific_ingredients" structure, which can also be populated through parsing the end of the ingredient list (e.g. phrases like "Origin of the milk: United Kingdom").
The origins of specific ingredients are now used during ingredients analysis to populate the origins field of matching ingredients.
For the Eco-Score, if we don't have an ingredients list (e.g. products that have a single ingredient like eggs often don't have an ingredient list filled), but if we have an ingredient specific origin (French eggs), we use that origin for the whole product.
Part of