Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix states and countries taxonomies, build taxonomies #6442

Merged
merged 2 commits into from
Feb 28, 2022
Merged

fix: fix states and countries taxonomies, build taxonomies #6442

merged 2 commits into from
Feb 28, 2022

Conversation

stephanegigandet
Copy link
Contributor

  • fixed some translations in states
  • removed some duplicate entries in countries (especially for Saint-Martin / Congo that refer to two countries)

Removing the duplicates is necessary to make the taxonomies build.

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Feb 25, 2022
@stephanegigandet stephanegigandet changed the title fix states and countries taxonomies, build taxonomies fix: fix states and countries taxonomies, build taxonomies Feb 25, 2022
@stephanegigandet stephanegigandet requested a review from a team February 25, 2022 11:03
@stephanegigandet stephanegigandet mentioned this pull request Feb 25, 2022
Closed
@teolemon teolemon requested a review from a team as a code owner February 25, 2022 16:56
@github-actions github-actions bot added GitHub Actions Pull requests that update Github_actions code 🧬 Taxonomies - Rebuild Taxonomies are compiled before they can be used. labels Feb 25, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 17faad1 into main Feb 28, 2022
@stephanegigandet stephanegigandet deleted the built-taxonomies branch February 28, 2022 13:00
@github-actions github-actions bot mentioned this pull request Feb 28, 2022
Merged
@teolemon teolemon added this to the V1.1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
GitHub Actions Pull requests that update Github_actions code 🧬 Taxonomies - Rebuild Taxonomies are compiled before they can be used. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @teolemon