Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ag barcode in search #6494

Merged
merged 1 commit into from
Mar 24, 2022
Merged

feat: Ag barcode in search #6494

merged 1 commit into from
Mar 24, 2022

Conversation

alexgarel
Copy link
Member

Description

Now in search preferences you can ask to have barcode and to have edit link.
It displays them in search results.

Screenshot

In user settings:

Capture d’écran de 2022-03-18 16-26-24

In search, with edit link and barcode:

Capture d’écran de 2022-03-18 16-26-47

Related issue(s) and discussion

@alexgarel alexgarel requested a review from a team as a code owner March 18, 2022 15:28
@github-actions github-actions bot added CSS Display 🐋 Docker https://docker-curriculum.com/ 📚 Documentation Documentation issues improve the project for everyone. icons Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users labels Mar 18, 2022
cgi/user.pl Outdated Show resolved Hide resolved
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works great, thank you @alexgarel !

And thanks for all the code improvements that you made in passing.

@stephanegigandet stephanegigandet changed the title Ag feat barcode in search feat: Ag barcode in search Mar 21, 2022
@alexgarel alexgarel force-pushed the ag-feat-barcode-in-search branch from 12f46c0 to b15fc79 Compare March 23, 2022 15:08
@CharlesNepote
Copy link
Member

About the edit link: there are already many informations on each card so in the Power User Script I used to display it only when the mouse is over the product.

@alexgarel alexgarel force-pushed the ag-feat-barcode-in-search branch from b15fc79 to 521d1cd Compare March 23, 2022 16:57
@github-actions github-actions bot removed the 📚 Documentation Documentation issues improve the project for everyone. label Mar 23, 2022
@alexgarel alexgarel force-pushed the ag-feat-barcode-in-search branch from 521d1cd to 8790af3 Compare March 24, 2022 11:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel merged commit 41fe83f into main Mar 24, 2022
@alexgarel alexgarel deleted the ag-feat-barcode-in-search branch March 24, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Display 🐋 Docker https://docker-curriculum.com/ icons Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users
Projects
None yet
3 participants