Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release please should trigger actions #6503

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: release please should trigger actions #6503

merged 1 commit into from
Mar 23, 2022

Conversation

alexgarel
Copy link
Member

We need actions to be triggered by release please this means using a personal access token instead of the default one.

The secret is already created in the repo.

@alexgarel alexgarel requested a review from a team as a code owner March 23, 2022 10:11
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Mar 23, 2022
@alexgarel alexgarel mentioned this pull request Mar 23, 2022
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will solve the fact that tests don't seem to run for release-please releases?

@stephanegigandet stephanegigandet merged commit 5d9836d into main Mar 23, 2022
@stephanegigandet stephanegigandet deleted the fix-release-please-token branch March 23, 2022 11:55
@teolemon teolemon added this to the V1.1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@alexgarel alexgarel

Labels
GitHub Actions Pull requests that update Github_actions code
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgarel @stephanegigandet @teolemon