Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wikidata entries to update #6619

Merged
merged 4 commits into from
Apr 15, 2022
Merged

fix: Wikidata entries to update #6619

merged 4 commits into from
Apr 15, 2022

Conversation

aadarsh-ram
Copy link
Contributor

Description

Wkidata entries get merged overtime. So, exceptions were generated in the Android app due to this merge.
Affected wikidata due to merge:

  • Q63534992
  • Q2366206

Related issue(s) and discussion

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner April 15, 2022 07:13
stephanegigandet
stephanegigandet approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

alexgarel
alexgarel requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Just a question on you first (or second) commit.

.github/workflows/github-projects.yml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aadarsh-ram
Copy link
Contributor Author

aadarsh-ram commented Apr 15, 2022 •
edited
Loading

@teolemon @stephanegigandet @alexgarel I noticed that the contributor images weren't being updated. It seems there is an issue in the Open Collective's contributors.svg generation. So, I added a new image generator which is also open-source.
Result: https://github.com/aadarsh-ram/openfoodfacts-server/tree/upd-taxonomy#contributors
Hope this is okay!

@aadarsh-ram aadarsh-ram requested a review from alexgarel April 15, 2022 10:21
@alexgarel alexgarel merged commit 383ab3e into openfoodfacts:main Apr 15, 2022
@alexgarel alexgarel mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wikidata entries to update
4 participants
@aadarsh-ram @alexgarel @teolemon @stephanegigandet