fix: "uninitialized" warning in the user form for professional accounts

[yuktea]

Description

Implements an additional check to see if an org associated with the user is defined before executing the code block.
This fixes an uninitialized value warning.

The error

[Sun Apr 17 11:00:58 2022] -e: Use of uninitialized value in concatenation (.) or string at /opt/product-opener/cgi/user.pl line 208.

[stephanegigandet]

So that definitely will solve the warning, but then it will prevent users to create a professional account. When users create an account, $user_ref->{org} is not defined (yet), but we want to display them the checkbox option to say that it is a professional account.

The warning field should probably be removed, and instead, we can change the template to display the warning message, only when needed.

Template is here : /templates/web/pages/user_form/user_form_page.tt.html

This part should be changed:

                    [% IF accepted_organization && section.id == "professional" %]
                        <p>[% field.warning %]</p>
                    [% ELSE %]
                        <label for="[% field.field %]">
                            <input type="checkbox" id="[% field.field %]" name="[% field.field %]" [% IF field.value == 'on' %]checked="checked"[% END %] />
                            [% field.label %]
                        </label>
                    [% END %]

the Lang.pm defines f_lang() and lang_sprintf() functions that can be used directly in the template.

[yuktea]

Thank you for reviewing! This is certainly a great approach to fix that warning.
I've pushed another commit with an update :)

[stephanegigandet]

Hi @yuktea , have you checked if it works? (you can do that by creating an account with the "this is a professional account" checkbox, and then editing the account).
I think it won't work as is, because f_lang() expects a different format than sprintf (%s vs something like ).
You can look at the strings in po/common/common.pot and po/common.en.po
The best solution is indeed to use f_lang(), but then you have to change the string.

e.g. here is an example for another string:

# variable names between { } must not be translated
msgctxt "f_move_data_and_photos_to_main_language"
msgid "Move all data and selected photos in {language} to the main language of the product: {main_language}"
msgstr "Move all data and selected photos in {language} to the main language of the product: {main_language}"

[stephanegigandet]

Looks good!

There's a line that I think is not used (and was not used before):

$template_data_ref->{pro_account_org} = sprintf(lang("this_is_a_pro_account_for_org"),"" . $user_ref->{org} . "");

[stephanegigandet]

Could you also remove the old string "this_is_a_pro_account_for_org" from the common.pot file?

[stephanegigandet]

Thank you!

[yuktea]

Looks good!

There's a line that I think is not used (and was not used before):

$template_data_ref->{pro_account_org} = sprintf(lang("this_is_a_pro_account_for_org"),"" . $user_ref->{org} . "");

Yes! was thinking the same. I'll clean this up

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication